From: Kevin Wolf <kwolf@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-block@nongnu.org, Jens Freimann <jfrei@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection
Date: Tue, 12 Jan 2016 15:25:21 +0100 [thread overview]
Message-ID: <20160112142521.GE4841@noname.redhat.com> (raw)
In-Reply-To: <1450107679-34555-1-git-send-email-borntraeger@de.ibm.com>
Am 14.12.2015 um 16:41 hat Christian Borntraeger geschrieben:
> Kevin,
>
> here is a fixup for the geometry detection. We tried to be overly
> clever and calculate the cyclinder size for devices > 64k cyls. Now
> this is wrong for the cyls parameter as the interface only has
> 16bit. Large DASD devices have a special token (0xfffe) that
> indicate to the DASD related code, that you have to calculate
> the cyls size yourself.
>
> Without this patch QEMU cannot pass through bigger DASD disks
> and complains "cyls must be between 1 and 65535"
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2016-01-12 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:41 [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection Christian Borntraeger
2015-12-14 15:41 ` [Qemu-devel] [PATCH 1/1] block/raw-posix: avoid bogus fixup for cylinders on DASD disks Christian Borntraeger
2015-12-14 17:42 ` Markus Armbruster
2015-12-14 17:49 ` Cornelia Huck
2016-01-07 9:23 ` Christian Borntraeger
2016-01-12 14:25 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112142521.GE4841@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).