From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIzt8-0002Gy-Lh for qemu-devel@nongnu.org; Tue, 12 Jan 2016 09:25:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIzt4-0005zP-U4 for qemu-devel@nongnu.org; Tue, 12 Jan 2016 09:25:34 -0500 Date: Tue, 12 Jan 2016 15:25:21 +0100 From: Kevin Wolf Message-ID: <20160112142521.GE4841@noname.redhat.com> References: <1450107679-34555-1-git-send-email-borntraeger@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450107679-34555-1-git-send-email-borntraeger@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Cornelia Huck , Ekaterina Tumanova , qemu-devel , qemu-block@nongnu.org, Jens Freimann Am 14.12.2015 um 16:41 hat Christian Borntraeger geschrieben: > Kevin, > > here is a fixup for the geometry detection. We tried to be overly > clever and calculate the cyclinder size for devices > 64k cyls. Now > this is wrong for the cyls parameter as the interface only has > 16bit. Large DASD devices have a special token (0xfffe) that > indicate to the DASD related code, that you have to calculate > the cyls size yourself. > > Without this patch QEMU cannot pass through bigger DASD disks > and complains "cyls must be between 1 and 65535" Thanks, applied to the block branch. Kevin