From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57807)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aJ0qc-0005db-T4
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 10:27:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aJ0qc-0007nI-1A
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 10:27:02 -0500
Date: Tue, 12 Jan 2016 16:26:54 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160112152654.GH4841@noname.redhat.com>
References: <1452578622-4492-1-git-send-email-den@openvz.org>
	<20160112141607.GD4841@noname.redhat.com>
	<569514E7.8090101@redhat.com> <56951813.5000402@openvz.org>
	<CAFEAcA8OgVxXt4LUUaWk7R2+oUpNYQ4UPpGE9gW6EE7bL_itCg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8OgVxXt4LUUaWk7R2+oUpNYQ4UPpGE9gW6EE7bL_itCg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for
 internal snapshot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Denis V. Lunev" <den@openvz.org>, Laszlo Ersek <lersek@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

Am 12.01.2016 um 16:16 hat Peter Maydell geschrieben:
> On 12 January 2016 at 15:13, Denis V. Lunev <den@openvz.org> wrote:
> > The idea of this patch was trivial. First of all, I would like to keep
> > this image internally snapshoted. That is why the ultimate goal
> > was to switch from raw to qcow2 to keep changes inside the
> > image.
> >
> > Though in this case this drive could be selected to save VM
> > state, which could be big. The function being changed selects
> > the image for VM state saving.
> >
> > here I would like to skip IP_PFLASH from being selected to keep
> > it small as required by libvirt guys.
> 
> This has to be a board specific decision. Some of our machine
> models might have no backing storage other than an IP_PFLASH
> drive, but it's still nice to be able to do vmsave/vmload on them.

Maybe we can give flash images lower priority than other images?

I'm not sure if we don't break compatibility with such a change, though.
loadvm on existing snapshots could fail now. We might need to change
that first so that it can find snapshots even on images that wouldn't be
the VM state image for new snapshots any more.

Kevin