From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ4ll-0006BI-Oh for qemu-devel@nongnu.org; Tue, 12 Jan 2016 14:38:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ4lh-0006Nn-Qw for qemu-devel@nongnu.org; Tue, 12 Jan 2016 14:38:17 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:38683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ4lh-0006NX-Fd for qemu-devel@nongnu.org; Tue, 12 Jan 2016 14:38:13 -0500 Received: by mail-wm0-x22a.google.com with SMTP id b14so337616239wmb.1 for ; Tue, 12 Jan 2016 11:38:12 -0800 (PST) Date: Tue, 12 Jan 2016 20:38:06 +0100 From: =?UTF-8?B?SmluZMWZaWNoIE1ha292acSNa2E=?= Message-ID: <20160112203806.682c8ebd@holly> In-Reply-To: <1452517816.8098.49.camel@redhat.com> References: <20151205133123.4f9f5035@holly> <87r3hoz47y.fsf@blackfin.pond.sub.org> <1452517816.8098.49.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/rsISIMpm8DcrpbH=yb0i6dm" Subject: Re: [Qemu-devel] [PATCH] sdl: shorten the GUI refresh interval when mouse or keyboard is active List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Markus Armbruster , qemu-devel@nongnu.org --MP_/rsISIMpm8DcrpbH=yb0i6dm Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Gerd, On Mon, 11 Jan 2016 14:10:16 +0100 Gerd Hoffmann wrote: > Hi, > > For SDL2 this ... > > > > +static int idle_counter; > > ... should be store in ... > > > > void sdl2_poll_events(struct sdl2_console *scon) > > ... sdl2_console, otherwise it will not work as intended in case > multiple windows are present. > > Otherwise looks fine to me. Updated patch attached. Regards, -- Jindrich Makovicka --MP_/rsISIMpm8DcrpbH=yb0i6dm Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-sdl-shorten-the-GUI-refresh-interval-when-mouse-or-k.patch =46rom 7f01ec81210ea16af33ebacf6a348618570131e8 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Jind=3DC5=3D99ich=3D20Makovi=3DC4=3D8Dka?=3D Date: Tue, 12 Jan 2016 20:18:24 +0100 Subject: [PATCH] sdl: shorten the GUI refresh interval when mouse or keyboa= rd is active MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jind=C5=99ich Makovi=C4=8Dka --- include/ui/sdl2.h | 1 + ui/sdl.c | 22 ++++++++++++++++++++++ ui/sdl2.c | 23 +++++++++++++++++++++++ 3 files changed, 46 insertions(+) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h index b7ac38f..3f0b57b 100644 --- a/include/ui/sdl2.h +++ b/include/ui/sdl2.h @@ -19,6 +19,7 @@ struct sdl2_console { int hidden; int opengl; int updates; + int idle_counter; SDL_GLContext winctx; #ifdef CONFIG_OPENGL ConsoleGLState *gls; diff --git a/ui/sdl.c b/ui/sdl.c index c837436..f215fe1 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -60,6 +60,11 @@ static SDL_Cursor *guest_sprite =3D NULL; static SDL_PixelFormat host_format; static int scaling_active =3D 0; static Notifier mouse_mode_notifier; +static int idle_counter; + +#define SDL_REFRESH_INTERVAL_BUSY 10 +#define SDL_MAX_IDLE_COUNT (2 * GUI_REFRESH_INTERVAL_DEFAULT \ + / SDL_REFRESH_INTERVAL_BUSY + 1) =20 #if 0 #define DEBUG_SDL @@ -802,6 +807,7 @@ static void handle_activation(SDL_Event *ev) static void sdl_refresh(DisplayChangeListener *dcl) { SDL_Event ev1, *ev =3D &ev1; + int idle =3D 1; =20 if (last_vm_running !=3D runstate_is_running()) { last_vm_running =3D runstate_is_running(); @@ -817,9 +823,11 @@ static void sdl_refresh(DisplayChangeListener *dcl) sdl_update(dcl, 0, 0, real_screen->w, real_screen->h); break; case SDL_KEYDOWN: + idle =3D 0; handle_keydown(ev); break; case SDL_KEYUP: + idle =3D 0; handle_keyup(ev); break; case SDL_QUIT: @@ -829,10 +837,12 @@ static void sdl_refresh(DisplayChangeListener *dcl) } break; case SDL_MOUSEMOTION: + idle =3D 0; handle_mousemotion(ev); break; case SDL_MOUSEBUTTONDOWN: case SDL_MOUSEBUTTONUP: + idle =3D 0; handle_mousebutton(ev); break; case SDL_ACTIVEEVENT: @@ -847,6 +857,18 @@ static void sdl_refresh(DisplayChangeListener *dcl) break; } } + + if (idle) { + if (idle_counter < SDL_MAX_IDLE_COUNT) { + idle_counter++; + if (idle_counter >=3D SDL_MAX_IDLE_COUNT) { + dcl->update_interval =3D GUI_REFRESH_INTERVAL_DEFAULT; + } + } + } else { + idle_counter =3D 0; + dcl->update_interval =3D SDL_REFRESH_INTERVAL_BUSY; + } } =20 static void sdl_mouse_warp(DisplayChangeListener *dcl, diff --git a/ui/sdl2.c b/ui/sdl2.c index 46270f4..c0a76d7 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -49,6 +49,10 @@ static int guest_x, guest_y; static SDL_Cursor *guest_sprite; static Notifier mouse_mode_notifier; =20 +#define SDL2_REFRESH_INTERVAL_BUSY 10 +#define SDL2_MAX_IDLE_COUNT (2 * GUI_REFRESH_INTERVAL_DEFAULT \ + / SDL2_REFRESH_INTERVAL_BUSY + 1) + static void sdl_update_caption(struct sdl2_console *scon); =20 static struct sdl2_console *get_scon_from_window(uint32_t window_id) @@ -578,6 +582,7 @@ static void handle_windowevent(SDL_Event *ev) void sdl2_poll_events(struct sdl2_console *scon) { SDL_Event ev1, *ev =3D &ev1; + int idle =3D 1; =20 if (scon->last_vm_running !=3D runstate_is_running()) { scon->last_vm_running =3D runstate_is_running(); @@ -587,12 +592,15 @@ void sdl2_poll_events(struct sdl2_console *scon) while (SDL_PollEvent(ev)) { switch (ev->type) { case SDL_KEYDOWN: + idle =3D 0; handle_keydown(ev); break; case SDL_KEYUP: + idle =3D 0; handle_keyup(ev); break; case SDL_TEXTINPUT: + idle =3D 0; handle_textinput(ev); break; case SDL_QUIT: @@ -602,13 +610,16 @@ void sdl2_poll_events(struct sdl2_console *scon) } break; case SDL_MOUSEMOTION: + idle =3D 0; handle_mousemotion(ev); break; case SDL_MOUSEBUTTONDOWN: case SDL_MOUSEBUTTONUP: + idle =3D 0; handle_mousebutton(ev); break; case SDL_MOUSEWHEEL: + idle =3D 0; handle_mousewheel(ev); break; case SDL_WINDOWEVENT: @@ -618,6 +629,18 @@ void sdl2_poll_events(struct sdl2_console *scon) break; } } + + if (idle) { + if (scon->idle_counter < SDL2_MAX_IDLE_COUNT) { + scon->idle_counter++; + if (scon->idle_counter >=3D SDL2_MAX_IDLE_COUNT) { + scon->dcl.update_interval =3D GUI_REFRESH_INTERVAL_DEFAULT; + } + } + } else { + scon->idle_counter =3D 0; + scon->dcl.update_interval =3D SDL2_REFRESH_INTERVAL_BUSY; + } } =20 static void sdl_mouse_warp(DisplayChangeListener *dcl, --=20 2.7.0.rc3 --MP_/rsISIMpm8DcrpbH=yb0i6dm--