Re: [Qemu-devel] [PATCH] net: set endianness on all backend devices

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Thu, 14 Jan 2016 09:01:49 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> On Wed, 13 Jan 2016 20:26:25 +0100
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
> > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991
> >        vhost-net: tell tap backend about the vnet endianness
> > 
> > makes vhost net to set the endianness of the device, but only for
> > the first device.
> > 
> > In case of multiqueue, we have multiple devices... This patch sets the
> > endianness for all the devices of the interface.
> > 
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> > ---
> 
> Thanks for fixing this bug... it's been there since 2.4.0. I guess we
> should backport this to 2.4 and 2.5. Cc'ing stable.

Agree on backporting this.

> Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> 
> >  hw/net/vhost_net.c | 23 +++++++++++------------
> >  1 file changed, 11 insertions(+), 12 deletions(-)
> > 
> > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> > index 318c3e6..10e233a 100644
> > --- a/hw/net/vhost_net.c
> > +++ b/hw/net/vhost_net.c
> > @@ -300,21 +300,19 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
> >      BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev)));
> >      VirtioBusState *vbus = VIRTIO_BUS(qbus);
> >      VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
> > -    int r, e, i;
> > +    int r, e, i, j;

Nice alphabet soup ;)

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>