qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Jeff Cody <jcody@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Max Reitz <mreitz@redhat.com>, Alberto Garcia <berto@igalia.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] Minutes from the "Stuttgart block Gipfele"
Date: Thu, 14 Jan 2016 11:25:35 +0000	[thread overview]
Message-ID: <20160114112535.GC3055@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160111151012.GC9454@noname.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Mon, Jan 11, 2016 at 04:10:12PM +0100, Kevin Wolf wrote:
> Am 23.12.2015 um 09:33 hat Stefan Hajnoczi geschrieben:
> > On Fri, Dec 18, 2015 at 02:15:38PM +0100, Markus Armbruster wrote:
> > Another problem is that the backup block job and other operations that
> > require a single command today could require sequences of low-level
> > setup commands to create filter nodes.  The QMP client would need to
> > first create a write notifier filter and then start the backup block job
> > with the write notifier node name.  It's clumsy.
> 
> I don't think splitting it up into several low-level commands is
> necessary. We don't expect the user to set any options for the filter
> (and if we did, they would probably have to match the same options for
> the block job), so we can keep the BDS creation as a part of starting
> the block job.
> 
> The important part is that the management tool knows that a filter is
> going to be inserted and how to address it. In order to achieve that, we
> could simply add a 'filter-node-name' option to the QMP command starting
> the job.

That sounds like a good approach.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-01-14 11:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 13:15 [Qemu-devel] Minutes from the "Stuttgart block Gipfele" Markus Armbruster
2015-12-23  8:33 ` Stefan Hajnoczi
2016-01-11 15:10   ` Kevin Wolf
2016-01-14 11:25     ` Stefan Hajnoczi [this message]
2015-12-23 10:15 ` Fam Zheng
2016-01-04  5:16   ` Stefan Hajnoczi
2016-01-04  7:28     ` Fam Zheng
2016-01-07  5:23       ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-01-07  9:32         ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160114112535.GC3055@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).