From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJl1T-0005xJ-1U for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:45:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJl1S-0000hN-8Q for qemu-devel@nongnu.org; Thu, 14 Jan 2016 11:45:18 -0500 Date: Thu, 14 Jan 2016 14:09:24 +0000 From: Stefan Hajnoczi Message-ID: <20160114140924.GF3055@stefanha-x1.localdomain> References: <1452537156-7683-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HCdXmnRlPgeNBad2" Content-Disposition: inline In-Reply-To: <1452537156-7683-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Fix .bdrv_open flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: borntraeger@de.ibm.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, den@openvz.org --HCdXmnRlPgeNBad2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 11, 2016 at 07:32:36PM +0100, Kevin Wolf wrote: > bdrv_common_open() modified bs->open_flags after inferring the set of > options to pass to the driver's .bdrv_open callback. This means that the > cache options were correctly set in bs->open_flags (and therefore > correctly displayed in 'info block'), but the image would actually be > opened with the default cache mode instead. >=20 > This patch removes the flags parameter to bdrv_common_open() (except for > BDRV_O_NO_BACKING it's the same as bs->open_flags anyway, and having two > names for the same thing is confusing), and moves the assignment of > open_flags down to immediately before calling into the block drivers. In > all other places, bs->open_flags is now used consistently. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Stefan Hajnoczi --HCdXmnRlPgeNBad2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWl6wUAAoJEJykq7OBq3PI15EH/3ppmaars/+i4jIwAZW6Fe4a h+kYTDjiGCdgAv/6QCV4bJRws3zwWHOoxPWUMYxQiJIZMURNViryVCWKZLQ9VbQ+ AAhuUpEHZI+O9p+Tp3keOPTAleXEcJdUHe9AkXw1QpwNCcXN79xeFU1LXEhlFurJ cPLNRmGVM6AlziRAYPy75QzThzDz7Sq6Dlp6tZG1R5MJPurQxQI7dB0G6evwzFvh rayUuhcnVcBvf590WUcOpxrL9MH+OXOu5tOFnvOeBov++YKCpNeFXGPq6fT1AE6F ETSVgimclmYb8BaITYdGH1erqaL0RTNuYzMWPKiSyesFAPhgTXhoY+mn1s6v/W0= =Km6q -----END PGP SIGNATURE----- --HCdXmnRlPgeNBad2--