From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJld3-00084b-V6 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 12:24:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJld2-0003UG-K8 for qemu-devel@nongnu.org; Thu, 14 Jan 2016 12:24:09 -0500 Date: Thu, 14 Jan 2016 17:23:59 +0000 From: "Daniel P. Berrange" Message-ID: <20160114172359.GD19340@redhat.com> References: <1452760863-25350-1-git-send-email-famz@redhat.com> <1452760863-25350-2-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452760863-25350-2-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/3] nbd: Always call "close_fn" in nbd_client_new Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org On Thu, Jan 14, 2016 at 04:41:01PM +0800, Fam Zheng wrote: > Rename the parameter "close" to "close_fn" to disambiguous with > close(2). > > This unifies error handling paths of NBDClient allocation: > nbd_client_new will shutdown the socket and call the "close_fn" callback > if negotiation failed, so the caller don't need a different path than > the normal close. > > The returned pointer is never used, make it void in preparation for the > next patch. > > Signed-off-by: Fam Zheng > --- > blockdev-nbd.c | 5 ++--- > include/block/nbd.h | 3 +-- > nbd.c | 11 +++++------ > qemu-nbd.c | 10 +++------- > 4 files changed, 11 insertions(+), 18 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|