From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aJlf9-0000u2-DU
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 12:26:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aJlf8-0004Gj-0U
	for qemu-devel@nongnu.org; Thu, 14 Jan 2016 12:26:19 -0500
Date: Thu, 14 Jan 2016 17:26:10 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160114172610.GE19340@redhat.com>
References: <1452760863-25350-1-git-send-email-famz@redhat.com>
	<1452760863-25350-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1452760863-25350-3-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/3] nbd: Split nbd.c
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Thu, Jan 14, 2016 at 04:41:02PM +0800, Fam Zheng wrote:
> We have NBD server code and client code, all mixed in a file. Now split
> them into separate files under nbd/, and update MAINTAINERS.
> 
> filter_nbd for iotest 083 is updated to keep the log filtered out.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  MAINTAINERS                  |   5 +-
>  Makefile.objs                |   3 +-
>  include/block/nbd-internal.h | 113 +++++++++++
>  nbd/Makefile.objs            |   1 +
>  nbd/client.c                 | 361 ++++++++++++++++++++++++++++++++++
>  nbd/common.c                 |  64 ++++++
>  nbd.c => nbd/server.c        | 451 +------------------------------------------
>  tests/qemu-iotests/083       |   2 +-
>  8 files changed, 547 insertions(+), 453 deletions(-)
>  create mode 100644 include/block/nbd-internal.h
>  create mode 100644 nbd/Makefile.objs
>  create mode 100644 nbd/client.c
>  create mode 100644 nbd/common.c
>  rename nbd.c => nbd/server.c (68%)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Splitting this up is well overdue. Though this will conflict
horribly with my TLS series, that's not the end of the world
if Paolo wishes to merge this quickly.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|