From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK6BP-0003mw-5J for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK6BK-0008SM-1K for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:20:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK6BJ-0008Rj-Ke for qemu-devel@nongnu.org; Fri, 15 Jan 2016 10:20:53 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 55B9EC0B7A30 for ; Fri, 15 Jan 2016 15:20:53 +0000 (UTC) Date: Fri, 15 Jan 2016 15:20:49 +0000 From: "Daniel P. Berrange" Message-ID: <20160115152049.GC2863@redhat.com> References: <1452871021-32405-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452871021-32405-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-char: do not leak QemuMutex when freeing a character device Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Fri, Jan 15, 2016 at 04:17:01PM +0100, Paolo Bonzini wrote: > The leak is only apparent on Win32. On POSIX platforms destroying a > mutex is not necessary. > > Reported-by: Eric Blake > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange > diff --git a/qemu-char.c b/qemu-char.c > index 02b0318..c7b8699 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3967,6 +3967,7 @@ static void qemu_chr_free_common(CharDriverState *chr) > if (chr->logfd != -1) { > close(chr->logfd); > } > + qemu_mutex_destroy(&chr->chr_write_lock); > g_free(chr); > } Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|