* [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16
@ 2016-01-13 16:03 Aurelien Jarno
2016-01-15 14:21 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2016-01-13 16:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Aurelien Jarno
The roundAndPackFloat16 function should return a float16 value, not a
float32 one. Fix that.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
fpu/softfloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Peter, given you are working on softfloat patches, you might want to get
this one merged at the same time.
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index f1170fe..acc9099 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -3368,7 +3368,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig)
| Binary Floating-Point Arithmetic.
*----------------------------------------------------------------------------*/
-static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
+static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
uint32_t zSig, flag ieee,
float_status *status)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16
2016-01-13 16:03 [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16 Aurelien Jarno
@ 2016-01-15 14:21 ` Peter Maydell
2016-01-17 17:40 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2016-01-15 14:21 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: QEMU Developers
On 13 January 2016 at 16:03, Aurelien Jarno <aurelien@aurel32.net> wrote:
> The roundAndPackFloat16 function should return a float16 value, not a
> float32 one. Fix that.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> fpu/softfloat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Peter, given you are working on softfloat patches, you might want to get
> this one merged at the same time.
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index f1170fe..acc9099 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -3368,7 +3368,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig)
> | Binary Floating-Point Arithmetic.
> *----------------------------------------------------------------------------*/
>
> -static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
> +static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
> uint32_t zSig, flag ieee,
> float_status *status)
> {
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(a harmless error in the current code but we might as well get it right).
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16
2016-01-15 14:21 ` Peter Maydell
@ 2016-01-17 17:40 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2016-01-17 17:40 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
On 2016-01-15 14:21, Peter Maydell wrote:
> On 13 January 2016 at 16:03, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > The roundAndPackFloat16 function should return a float16 value, not a
> > float32 one. Fix that.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> > fpu/softfloat.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Peter, given you are working on softfloat patches, you might want to get
> > this one merged at the same time.
> >
> > diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> > index f1170fe..acc9099 100644
> > --- a/fpu/softfloat.c
> > +++ b/fpu/softfloat.c
> > @@ -3368,7 +3368,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig)
> > | Binary Floating-Point Arithmetic.
> > *----------------------------------------------------------------------------*/
> >
> > -static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
> > +static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
> > uint32_t zSig, flag ieee,
> > float_status *status)
> > {
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> (a harmless error in the current code but we might as well get it right).
It's harmless in the default build, but it fails to build when softfloat
type checking is activated. Unfortunately more code with the wrong type
has been added recently.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-17 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-13 16:03 [Qemu-devel] [PATCH RESEND] softfloat: fix return type of roundAndPackFloat16 Aurelien Jarno
2016-01-15 14:21 ` Peter Maydell
2016-01-17 17:40 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).