From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKyXu-0003ZY-4l for qemu-devel@nongnu.org; Sun, 17 Jan 2016 20:23:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKyXs-0001Uv-Ug for qemu-devel@nongnu.org; Sun, 17 Jan 2016 20:23:50 -0500 Date: Mon, 18 Jan 2016 12:24:41 +1100 From: David Gibson Message-ID: <20160118012441.GD9301@voom.fritz.box> References: <1452906886-806-1-git-send-email-david@gibson.dropbear.id.au> <569C2917.9010908@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YkJPYEFdoxh/AXLE" Content-Disposition: inline In-Reply-To: <569C2917.9010908@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH 0/3] Reduce abuse of rtas_st / rtas_ld List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com, agraf@suse.de --YkJPYEFdoxh/AXLE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2016 at 10:51:51AM +1100, Alexey Kardashevskiy wrote: > On 01/16/2016 12:14 PM, David Gibson wrote: > >The rtas_ld() and rtas_st() helpers were designed for loading RTAS > >arguments and storing RTAS returns which are in a simple, common array > >format. > > > >However, a number of RTAS routines - and even non-RTAS routines - have > >started using these for accessing other memory buffers, where the > >normal qemu memory access routines would be more appropriate. > > > >This series removes some of these abuses of the RTAS accessors. >=20 > imho simple renaming rtas_st to stl_be_phys_real (and so on for other > rtas_xx) would make more sense as rtas_st&co do not have to do anything w= ith > RTAS itself, it is all about realmode guest memory access=D0=B1 RTAS just > happened to be the first client of it. Well, no. They were designed, specifically, to be a concise way to load RTAS arguments, and store RTAS returns. Nothing more. To match other ldl* routines they would need to change to not take the 'n' argument, which would make using them more awkward for the exact use case they're intended for. I did consider adding ldXX_real() routines for all the memory access cases these have been abused for, but they're few enough that it seems simpler just to open code them in terms of the base memory access routines. =20 > btw in st_cc_buf(), what does "cc" stand for? "configure connector" - it's a helper just for that routine. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --YkJPYEFdoxh/AXLE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnD7ZAAoJEGw4ysog2bOSdnEQAMJDOSTehbLoL18XEiWmRaZs h9/PTOl9jo1MmedMpjCLNOkDi7ZXCb2b3gYa4dp7qYFYLAgq85+zU4Pai4vzNydd v2R43cT1IgPrkEPsjJPv9X042/CO+B9+DVd0i6ZmiTlJ+ItEJsBUfd/tG/ZnbseD eoH/pNH+Z44WKyqYqYxCTlWi6FN9W2UVn179ILLlqw8uCVjdBmb4PsAKe6DJqJYx p1N3yj4QHtooXQVZMxuWTjNZoHzx+ytwObLrdGA4KsAp5W1GM+F3v8DyyFpv+Qz8 1X56lXWWwAd5KO8G7jVJL9uXyTGMqc76JK42ab/pN9iP2EaX02g9ZK5yjo+h5MmJ jHKv6y3MdW9napap+FW8CRQHrTK07YWedcYP6aN35q8bWLqUfofElZgeBh1Ufy9Y RrJ5GWS5PGBcYahMFMsgyn3SY1C4YnRNuyDrUtAnDW2dj/7YtC/ylp+1OfmJFnXU z0Kxc2GU+mG4D6eeobwcgxdOrx+42EfiaiWl0s8oVoREzLJ7AZ9xD77cBA0q5dWx j4dCopBeas6ozCnvNtIuyImuXeyN4RZW1MtNULy0qjfgeVvpXLo1a27je8gl9ytB V0OsMOdWb09ctCax+PmOk60NAdHkNzNJ62Xln4x+7leZHz/sO236NbFbK8/HsToE 5zvRNDRGl055Sd1RDduj =K68O -----END PGP SIGNATURE----- --YkJPYEFdoxh/AXLE--