From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL7D1-0004Fk-N2 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:38:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aL7Cy-0005VZ-FH for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:38:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aL7Cy-0005VU-9h for qemu-devel@nongnu.org; Mon, 18 Jan 2016 05:38:48 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B32FA3407F3 for ; Mon, 18 Jan 2016 10:38:46 +0000 (UTC) Date: Mon, 18 Jan 2016 10:38:43 +0000 From: "Daniel P. Berrange" Message-ID: <20160118103843.GD13395@redhat.com> References: <1453112751-725-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1453112751-725-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-char: avoid leak in qemu_chr_open_pp_fd Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Mon, Jan 18, 2016 at 11:25:51AM +0100, Paolo Bonzini wrote: > drv leaks if qemu_chr_alloc returns an error. > > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|