From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] fsdev: use error_report() instead of fprintf(stderr)
Date: Mon, 18 Jan 2016 16:02:46 +0100 [thread overview]
Message-ID: <20160118150246.30699.74556.stgit@bahia.huguette.org> (raw)
In-Reply-To: <20160118150234.30699.57180.stgit@bahia.huguette.org>
Only fix the code that gets built into QEMU.
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
fsdev/qemu-fsdev.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
index ccfec139ab2b..55e2f7a0fb58 100644
--- a/fsdev/qemu-fsdev.c
+++ b/fsdev/qemu-fsdev.c
@@ -17,6 +17,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "qemu/config-file.h"
+#include "qemu/error-report.h"
static QTAILQ_HEAD(FsDriverEntry_head, FsDriverListEntry) fsdriver_entries =
QTAILQ_HEAD_INITIALIZER(fsdriver_entries);
@@ -40,7 +41,7 @@ int qemu_fsdev_add(QemuOpts *opts)
bool ro = qemu_opt_get_bool(opts, "readonly", 0);
if (!fsdev_id) {
- fprintf(stderr, "fsdev: No id specified\n");
+ error_report("fsdev: No id specified");
return -1;
}
@@ -52,11 +53,11 @@ int qemu_fsdev_add(QemuOpts *opts)
}
if (i == ARRAY_SIZE(FsDrivers)) {
- fprintf(stderr, "fsdev: fsdriver %s not found\n", fsdriver);
+ error_report("fsdev: fsdriver %s not found", fsdriver);
return -1;
}
} else {
- fprintf(stderr, "fsdev: No fsdriver specified\n");
+ error_report("fsdev: No fsdriver specified");
return -1;
}
next prev parent reply other threads:[~2016-01-18 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 15:02 [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr) Greg Kurz
2016-01-18 15:02 ` [Qemu-devel] [PATCH 1/2] 9pfs: " Greg Kurz
2016-01-18 16:35 ` Markus Armbruster
2016-01-19 11:25 ` Greg Kurz
2016-01-18 15:02 ` Greg Kurz [this message]
2016-01-18 16:39 ` [Qemu-devel] [PATCH 0/2] 9pfs: fsdev: " Markus Armbruster
2016-01-19 11:28 ` Greg Kurz
2016-01-19 12:19 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118150246.30699.74556.stgit@bahia.huguette.org \
--to=gkurz@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).