From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44302)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aLEXu-0000Xk-Rj
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 13:28:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aLEXr-00085w-NB
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 13:28:54 -0500
Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:59850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aLEXr-00085k-D8
	for qemu-devel@nongnu.org; Mon, 18 Jan 2016 13:28:51 -0500
Received: from localhost
	by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Mon, 18 Jan 2016 18:28:49 -0000
Date: Mon, 18 Jan 2016 19:28:43 +0100
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20160118192843.55ef9d93@bahia.huguette.org>
In-Reply-To: <569D22F6.5070104@msgid.tls.msk.ru>
References: <20160111173036.24764.59878.stgit@bahia.huguette.org>
	<569D22F6.5070104@msgid.tls.msk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Mon, 18 Jan 2016 20:37:58 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 11.01.2016 20:30, Greg Kurz wrote:
> 
> > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
> > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64  
> ...
> 
> I'm not sure what's the value of this.  It's fine either way, no?

The only value is to drop unneeded stuff... and maybe some consistency
with the traces that don't have these trailing empty strings.

> Do we have a rule for trailing empty strings in coding style? :)
> 

Nor we have against parenthesitis, which brings a lot more unneeded
characters into the code :P

More seriously, I posted this because it was discussed earlier this month.

But honestly, I don't care if you don't want to push it. :)

> Thanks,
> 
> /mjt
> 

Cheers.

--
Greg