From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLJvH-0003OZ-BQ for qemu-devel@nongnu.org; Mon, 18 Jan 2016 19:13:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLJvE-0006EZ-2z for qemu-devel@nongnu.org; Mon, 18 Jan 2016 19:13:23 -0500 Date: Tue, 19 Jan 2016 11:11:50 +1100 From: David Gibson Message-ID: <20160119001150.GP9301@voom.fritz.box> References: <1452104533-8516-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1452104533-8516-3-git-send-email-mark.cave-ayland@ilande.co.uk> <568F1E1C.6000308@ozlabs.ru> <20160118031203.GJ9301@voom.fritz.box> <569CA2C6.1010400@ilande.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ngPZezdD7QsvFaqQ" Content-Disposition: inline In-Reply-To: <569CA2C6.1010400@ilande.co.uk> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] target-ppc: use cpu_write_xer() helper in cpu_post_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: quintela@redhat.com, Alexey Kardashevskiy , agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, amit.shah@redhat.com --ngPZezdD7QsvFaqQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2016 at 08:31:02AM +0000, Mark Cave-Ayland wrote: > On 18/01/16 03:12, David Gibson wrote: >=20 > > On Fri, Jan 08, 2016 at 01:25:32PM +1100, Alexey Kardashevskiy wrote: > >> On 01/07/2016 05:22 AM, Mark Cave-Ayland wrote: > >>> Otherwise some internal xer variables fail to get set post-migration. > >>> > >>> Signed-off-by: Mark Cave-Ayland > >>> --- > >>> target-ppc/machine.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/target-ppc/machine.c b/target-ppc/machine.c > >>> index 98fc63a..322ce84 100644 > >>> --- a/target-ppc/machine.c > >>> +++ b/target-ppc/machine.c > >>> @@ -168,7 +168,7 @@ static int cpu_post_load(void *opaque, int versio= n_id) > >>> env->spr[SPR_PVR] =3D env->spr_cb[SPR_PVR].default_value; > >>> env->lr =3D env->spr[SPR_LR]; > >>> env->ctr =3D env->spr[SPR_CTR]; > >>> - env->xer =3D env->spr[SPR_XER]; > >>> + cpu_write_xer(env, env->spr[SPR_XER]); > >>> #if defined(TARGET_PPC64) > >>> env->cfar =3D env->spr[SPR_CFAR]; > >>> #endif > >>> > >> > >> Reviewed-by: Alexey Kardashevskiy =09 > >=20 > > I've merged just this patch into ppc-for-2.6. The others in the > > series have some problems which have been pointed out elsewhere. >=20 > Thanks David. >=20 > Any chance of being able to merge the macio VMStateDescription patchset > too at > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00558.html? > (this was sent without an explicit CC as I didn't know you were still > handling ppc-next). *digs through mail archive* Ok, done. One small nit, as noted in the discussion 2/4 introduces a migration breakage. That's ok, since migration was broken beforehand anyway, but I think it would make sense to set the minimum_version_id to document the fact that you're dropping compatibility with all older versions. I'm happy for that to be a followup change though. > With the macio fixes in place then Mac machine migration should start to > work once the respin of this series is applied. >=20 >=20 > Many thanks, >=20 > Mark. >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ngPZezdD7QsvFaqQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnX9GAAoJEGw4ysog2bOS1cYP/3tx1ovRQYhct9N1RZKiAoIK 8MjBNW8We+Qf5I1aImL/bcz87asodCBbLtPxgSpKtJ9QIS+WdGeZwwuRRfrO0xcN 5AC3ElWqM0uOoK/zQvOmqseuGyE8Z5+Mliah1wWEfq+RfUkXtdbN0ftPMaDz4+9o X8vBlZjyklCiQJl4UPD50l0x8vauHcMeMCns5I2l66l4j6fAOlcC3AlazmLnY/18 tBNo2Z/FIGHRBNvWjc1EWifbJUg7RGMd09BEv/2Jzk8oEg+PUZXd90/Ts/seyfTg sRUqQng4esp7VKw5vMoxs3vHHfM0JJTt85vqBFxvrqI6QEMsYuj2ciLev2Yx25fD v6Pb3MJAj/h9s0d3qBLuDFOZ/TZ8np4v0+YZRb00H5B7hZEu3mA/wo7wYzi33zRc /gcF4vxXb1G8CfZjOnd7RnlT9FVEEFdOCepvUQxKGLEc6j5aVVPNwEbe7lDfq9CC vkBfl5rHt1rnbnoGTl+8wRLwudJepolhT6r02SK5l8BigLj6WMv7BUJCxPx7S7Bb FMP69UNXiHad4a3KUWRNhRYeVwisDGr7wRsKEYthS9hu/R+BG3wNyvgRcHFTAHrh o9+UJLtLPRR+D8b070ZX6RdNEPbgh8W8p1xinT6Dpo8rHLyksV+FDYMEoR2Xze/E 8Yw46adlgHvN9zBvpmKT =Dj5Z -----END PGP SIGNATURE----- --ngPZezdD7QsvFaqQ--