From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLKN6-0000LU-Ta for qemu-devel@nongnu.org; Mon, 18 Jan 2016 19:42:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLKN3-0003jf-Oa for qemu-devel@nongnu.org; Mon, 18 Jan 2016 19:42:08 -0500 Date: Tue, 19 Jan 2016 11:37:12 +1100 From: David Gibson Message-ID: <20160119003712.GS9301@voom.fritz.box> References: <1453091992-961-1-git-send-email-david@gibson.dropbear.id.au> <569D24AA.6010507@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GAoked8QSizNecZ5" Content-Disposition: inline In-Reply-To: <569D24AA.6010507@suse.de> Subject: Re: [Qemu-devel] [PATCH] sysbus: Remove ignored return value of FindSysbusDeviceFunc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: scottwood@freescale.com, peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org --GAoked8QSizNecZ5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2016 at 06:45:14PM +0100, Andreas F=E4rber wrote: > Am 18.01.2016 um 05:39 schrieb David Gibson: > > Functions of type FindSysbusDeviceFunc currently return an integer. I > > recently made an error in a patch because I assumed that this return va= lue > > would control whether iteration of the function across devices continues > > or not. In fact, the function's return value is always ignored. > >=20 > > This changes the function type to return void, so that others don't make > > the same mistake. >=20 > Have you considered implementing the behavior you expected? :) > Not necessary for your use case or too complicated? A bit of both. > > Signed-off-by: David Gibson > > --- > >=20 > > Please apply. >=20 > Patch looks okay, too short notice for today's pull though. > Usually we avoid "I" in a commit message. True, that probably won't make so much sense sitting in the commit history. I'll reword and resend. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GAoked8QSizNecZ5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWnYU4AAoJEGw4ysog2bOSeqkQAM5MEeqJI7/GCy1mnz7YVB3J m+nwAjPxuWqshoJY4m5qMSSHUEPMqsRQNG/nkZzmx3w1Q82Ho7u30q+z/jju/810 9m3zQzhwJO18WEshRdpacFtcBtxjdQOGvojuO+cWQAdD2qCdA0aPMi0wkamJEWxj vdWcnpMaL/UU8sYTURoMsl+uDnvATJ31I5D07Hski+aO6AjjK1v91UFIbaSIkj25 FI007GOXDesTtjzvZ7ybx/0u8tEpUiP/c4qYuJUIbUbEjXo9gItuzM9xXWlJjQpI TuGY96HQ2lmtEwjBt3DJuufT9f/vbq2xzF9f7Hzopbc3NdsWJovA9sz7WIGy2lVF oLojUGzyBts34j1zfv3yMV5vwkld9d+WhRLnQAbz7S0pynsMfQoCuaDkfM7cME8D TsWxJcG/Uethp87KBhr/0K8ViWCUl7J6uDYLmR69FUEqRjQrC0W234cX3SeexDNk jvyMcJAmxLCnTGWIppF80aWZSQ33TyXqpDUDyADdQuX+S2sk+ouMgxfL21B9FEut vMRU2sPYuZ0Mye1CQsYTVlf4zPgOwPfS+POyPOQorU7eCa03XPitqdZA9yE0EKFe rqR2miPtoneuAOQkerzu94R0rRwNWJjIPOgN8SlxBh0FXtB7IUMeo961WR2QQkKl xFH11UbubN+oxBxZlSiR =dHHQ -----END PGP SIGNATURE----- --GAoked8QSizNecZ5--