From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLPYW-0005sD-GW for qemu-devel@nongnu.org; Tue, 19 Jan 2016 01:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLPYV-0008Ac-GD for qemu-devel@nongnu.org; Tue, 19 Jan 2016 01:14:16 -0500 Date: Tue, 19 Jan 2016 15:59:12 +1100 From: David Gibson Message-ID: <20160119045912.GA27454@voom.redhat.com> References: <1453177824-27408-1-git-send-email-david@gibson.dropbear.id.au> <1453177824-27408-2-git-send-email-david@gibson.dropbear.id.au> <569DBDB1.3050405@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <569DBDB1.3050405@gmail.com> Subject: Re: [Qemu-devel] [PATCHv2 1/3] spapr: Small fixes to rtas_ibm_get_system_parameter, remove rtas_st_buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: lvivier@redhat.com, agraf@suse.de, thuth@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 19, 2016 at 03:38:09PM +1100, Alexey Kardashevskiy wrote: > On 01/19/2016 03:30 PM, David Gibson wrote: > >rtas_st_buffer() appears in spapr.h as though it were a widely used help= er, > >but in fact it is only used for saving data in a format used by > >rtas_ibm_get_system_parameter(). This changes it to a local helper more > >specifically for that function. > > > >While we're there fix a couple of small defects in > >rtas_ibm_get_system_parameter: > > - For the string value SPLPAR_CHARACTERISTICS, it wasn't including the > > terminating \0 in the length which it should according to LoPAPR > > 7.3.16.1 > > - It now checks that the supplied buffer has at least enough space for > > the length of the returned data, and returns an error if it does no= t. > > > >Signed-off-by: David Gibson > >--- > > hw/ppc/spapr_rtas.c | 22 ++++++++++++++++++---- > > include/hw/ppc/spapr.h | 28 +++++++++------------------- > > 2 files changed, 27 insertions(+), 23 deletions(-) > > > >diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > >index 34b12a3..32cdd66 100644 > >--- a/hw/ppc/spapr_rtas.c > >+++ b/hw/ppc/spapr_rtas.c > >@@ -228,6 +228,20 @@ static void rtas_stop_self(PowerPCCPU *cpu, sPAPRMa= chineState *spapr, > > env->msr =3D 0; > > } > > > >+ >=20 >=20 > Nit: unneeded empty line. Besides that, Ah, yes, fixed. > Reviewed-by: Alexey Kardashevskiy Thanks, I've merged this series into ppc-for-2.6. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWncKgAAoJEGw4ysog2bOSzTsQAINjDdKxX8V2WtYhR8oECDS6 1/hJGk143VTEoHFet1xKLkfO8e5/rBUbrZb2KImd35zQQZ/zth6TS0OWYp1dAPfb 1s7UY3QdV75x3b7V2d7Y1okjZy0eCo4t7O43cDofolFiLSiuDDqCwxlXOBvVBNas L4ruszrnD0/kvUGwla1sn+HXwgoi/hsgf6e0sYFvgwhMegm7gzis9Y3+qQlwf4Kd WUC1eKxq/1hfDDadsDKwYDrSJgHeDwRKSP/VR/qWMyF/8LkZnedOCEKwhxTcMhkX WuyKev5fy+8eJkgrfp/YP1x9ch7i4O2hkoSmFce1Agn+RU/i2oEWJVSBzROD9tEt BdM9UmFhjnrpATfW1MJZYQSOuq0y9gqFj/9DT8kD7/FXjm3t9aoL6NUxvt9YiB6s Jn79YrOmEyGiJz36ej8v1Jrg4YDDH8Vbd+dL+bJNd2ZVZM2ZvFCrh/p9qF0MB01W RgNIBaB8CguvL3Cpcg2A3WOveB+Yu+IHtTK2bPEMKhMMrVW7J87i9DguctoJ5ayM HOAnxJ5eYg75r+jaC8SaB2LsMjIC1kDvI97LRfP1Vu4k3GV5jvCPvqQx7IOx+Cr1 38T4HwgFQewtkqFYKzxmQ2pt3jKUBdn32f4T52Wl+fpmmz8n6P4AzmrGIVqVOwWd jkUHixy+ZzHbd0J7Bm2X =XtIX -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--