From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aLSn8-0004XQ-S1
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 04:41:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aLSn7-0000qS-OD
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 04:41:34 -0500
Date: Tue, 19 Jan 2016 09:41:22 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160119094122.GA26662@redhat.com>
References: <1452624982-19332-1-git-send-email-berrange@redhat.com>
	<1452624982-19332-6-git-send-email-berrange@redhat.com>
	<5696E06F.7060906@redhat.com> <20160114121604.GM910@redhat.com>
	<569D41A8.3000708@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <569D41A8.3000708@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption
 framework
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

On Mon, Jan 18, 2016 at 12:48:56PM -0700, Eric Blake wrote:
> On 01/14/2016 05:16 AM, Daniel P. Berrange wrote:
> 
> >>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use
> >>> +#
> >>
> >> Well, the only reason to use it would be to read data off an old
> >> insecurely-encrypted qcow2 file; so maybe it should read "Do not use on
> >> new files"
> > 
> > Yep
> > 
> >>> +# Since: 2.6
> >>> +##
> >>> +{ 'enum': 'QCryptoBlockFormat',
> >>> +#  'prefix': 'QCRYPTO_BLOCK_FORMAT',
> >>> +  'data': ['qcowaes']}
> >>
> >> Would 'qcow-aes' be any easier to read?
> > 
> > Or just shorten to 'qcow' perhaps ?
> 
> Or maybe 'old-qcow' to emphasize that it is old?  At this point, we're
> painting the bikeshed, so I'll live with whatever you like.

I've gone for just 'qcow', since that's also what libvirt calls it,
and it avoids a need for further debate as to whether to hyphenate
the two words or underscore or neither ;-P

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|