From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLYw8-0003yH-Ec for qemu-devel@nongnu.org; Tue, 19 Jan 2016 11:15:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLYw4-0003X5-7n for qemu-devel@nongnu.org; Tue, 19 Jan 2016 11:15:16 -0500 Date: Tue, 19 Jan 2016 17:15:04 +0100 From: Kevin Wolf Message-ID: <20160119161504.GC4579@noname.redhat.com> References: <1449804437-30373-1-git-send-email-eblake@redhat.com> <566B770C.8070308@redhat.com> <56747099.4000006@redhat.com> <56747F60.8030000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56747F60.8030000@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Reduce racy output in 028 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org, "open list:Block layer core" Am 18.12.2015 um 22:49 hat John Snow geschrieben: > > > On 12/18/2015 03:46 PM, Eric Blake wrote: > > On 12/11/2015 06:23 PM, John Snow wrote: > >> On 12/10/2015 10:27 PM, Eric Blake wrote: > >>> On my machine, './check -qcow2 028' was failing about 80% of the > >>> time, due to a race in how many times the repeated attempts > >>> to run 'info block-jobs' could occur before the job was done, > >>> showing up as a failure of fewer '(qemu) ' prompts than in the > >>> expected output. Silence the output during the repetitions, then > >>> add a final clean command to keep the expected output useful; > >>> once patched, I was finally able to run the test 20 times in a > >>> row with no failures. > It looks sane to me, because you are deleting the insane portion of the > expected output. The final "info block" command serves as an assertion > that the loop polled successfully. > > Reviewed-by: John Snow Thanks, applied to the block branch. Kevin