From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aLkNQ-0008Sk-Rb
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 23:28:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aLkNQ-0004zK-2y
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 23:28:12 -0500
Date: Wed, 20 Jan 2016 12:28:01 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160120042801.GB3164@ad.usersys.redhat.com>
References: <1442466250-27787-1-git-send-email-famz@redhat.com>
	<20150917085555.GB4884@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150917085555.GB4884@noname.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, rgerganov@vmware.com

On Thu, 09/17 10:55, Kevin Wolf wrote:
> Am 17.09.2015 um 07:04 hat Fam Zheng geschrieben:
> > VMware products accept only version 3 for streamOptimized, let's bump
> > the version.
> > 
> > Reported-by: Radoslav Gerganov <rgerganov@vmware.com>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> Radoslav, can I have your Reviewed-by and/or Tested-by for this patch?

Kevin, RHBZ 1299116 confirms that using version 3 for streamOptimized will make
VMware products happy. Could you apply this patch?

Fam

> 
> Kevin
> 
> >  block/vmdk.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/block/vmdk.c b/block/vmdk.c
> > index be0d640..37326c3 100644
> > --- a/block/vmdk.c
> > +++ b/block/vmdk.c
> > @@ -1651,7 +1651,13 @@ static int vmdk_create_extent(const char *filename, int64_t filesize,
> >      }
> >      magic = cpu_to_be32(VMDK4_MAGIC);
> >      memset(&header, 0, sizeof(header));
> > -    header.version = zeroed_grain ? 2 : 1;
> > +    if (compress) {
> > +        header.version = 3;
> > +    } else if (zeroed_grain) {
> > +        header.version = 2;
> > +    } else {
> > +        header.version = 1;
> > +    }
> >      header.flags = VMDK4_FLAG_RGD | VMDK4_FLAG_NL_DETECT
> >                     | (compress ? VMDK4_FLAG_COMPRESS | VMDK4_FLAG_MARKER : 0)
> >                     | (zeroed_grain ? VMDK4_FLAG_ZERO_GRAIN : 0);
> > -- 
> > 2.4.3
> >