From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLlME-0005vE-D3 for qemu-devel@nongnu.org; Wed, 20 Jan 2016 00:31:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLlMB-0002Dx-7a for qemu-devel@nongnu.org; Wed, 20 Jan 2016 00:31:02 -0500 Received: from e28smtp04.in.ibm.com ([125.16.236.4]:54091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLlMA-0002Dc-Hb for qemu-devel@nongnu.org; Wed, 20 Jan 2016 00:30:59 -0500 Received: from localhost by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Jan 2016 11:00:54 +0530 Date: Wed, 20 Jan 2016 11:00:39 +0530 From: Bharata B Rao Message-ID: <20160120053039.GA18882@in.ibm.com> References: <1453178361-24244-1-git-send-email-bharata@linux.vnet.ibm.com> <20160119050025.GB27454@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160119050025.GB27454@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Tue, Jan 19, 2016 at 04:00:25PM +1100, David Gibson wrote: > On Tue, Jan 19, 2016 at 10:09:21AM +0530, Bharata B Rao wrote: > > If guest doesn't have any dynamically reconfigurable (DR) logical memory > > blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-memory > > device tree node. > > > > Signed-off-by: Bharata B Rao > > --- > > This applies against ppc-for-2.6 branch of David Gibson's tree. > > Applied to ppc-for-2.6, thanks. There is a slight change in memory nodes representation in DT after this fix that could result in the following behaviour before and after migration. For a guest with -m 4G -numa node,nodeid=0,mem=2G -numa node,nodeid=1,mem=2G, the DT under /proc/device-tree changes like this: Guest started with QEMU w/o this fix ------------------------------------ memory@0 memory@80000000 ibm,dynamic-reconfiguration-memory Guest migrated to QEMU w/ this fix included ------------------------------------------- memory@0 memory@80000000 ibm,dynamic-reconfiguration-memory After next reboot ----------------- memory@0 memory@80000000 I guess this is ok, but wanted to sound out this change explicitly. Regards, Bharata.