From: Stefan Hajnoczi <stefanha@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Juan Quintela" <quintela@redhat.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Gabriel L. Somlo" <somlo@cmu.edu>,
qemu-devel@nongnu.org, "Kevin O'Connor" <kevin@koconnor.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc Marí" <markmb@redhat.com>, Laszlo <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version
Date: Thu, 21 Jan 2016 10:02:24 +0000 [thread overview]
Message-ID: <20160121100224.GB3671@stefanha-x1.localdomain> (raw)
In-Reply-To: <1453205507.18326.61.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On Tue, Jan 19, 2016 at 01:11:47PM +0100, Gerd Hoffmann wrote:
> > If you really think they should be merged, I'd even propose to
> > merge the ASM version onto the C version (convert this patch into
> > linuxboot.S). This slightly improves readability.
>
> Fully agree. I'm personally fine with having two roms, but when merging
> them into one we surely should ditch the fw_cfg asm macros and go with
> something more maintainable.
There is no technical requirement for a unified linuxboot ROM. If there
is no disadvantage to having 2 ROMs then let's stick to Marc's approach.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-01-21 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 9:59 [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version Marc Marí
2016-01-18 10:38 ` Paolo Bonzini
2016-01-18 14:42 ` Stefan Hajnoczi
2016-01-18 16:22 ` Marc Marí
2016-01-18 17:10 ` Kevin O'Connor
2016-01-19 12:11 ` Gerd Hoffmann
2016-01-21 10:02 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121100224.GB3671@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=markmb@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=somlo@cmu.edu \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).