From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMI5x-00025A-OL for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:28:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMI5u-0001bq-Az for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:28:25 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:45107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMI5u-0001ba-18 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 11:28:22 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Jan 2016 16:28:20 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id D00E21B08074 for ; Thu, 21 Jan 2016 16:28:23 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0LGSIHx4587798 for ; Thu, 21 Jan 2016 16:28:18 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0LFSJpG012690 for ; Thu, 21 Jan 2016 08:28:20 -0700 Date: Thu, 21 Jan 2016 17:28:16 +0100 From: Cornelia Huck Message-ID: <20160121172816.72cddd51.cornelia.huck@de.ibm.com> In-Reply-To: <56A10481.1020009@de.ibm.com> References: <1449144881-130935-1-git-send-email-borntraeger@de.ibm.com> <5697B045.4060500@de.ibm.com> <56A10481.1020009@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] gdb: provide the name of the architecture in the target.xml List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Peter Maydell , qemu-devel , David Hildenbrand On Thu, 21 Jan 2016 17:17:05 +0100 Christian Borntraeger wrote: > On 01/15/2016 03:18 PM, Peter Maydell wrote: > > On 14 January 2016 at 14:27, Christian Borntraeger > > wrote: > >> Ping? > >> > >> On 12/03/2015 01:14 PM, Christian Borntraeger wrote: > >>> From: David Hildenbrand > >>> > >>> This patch provides the name of the architecture in the target.xml > >>> if available. > >>> > >>> This allows the remote gdb to detect the target architecture on its > >>> own - so there is no need to specify it manually (e.g. if gdb is > >>> started without a binary) using "set arch *arch_name*". > >>> > >>> The name of the architecture is provided by a callback that can > >>> be implemented by all architectures. The arm implementation has > >>> special handling for iwmmxt and returns arm otherwise. This can > >>> be extended if necessary. > >>> > >>> Signed-off-by: David Hildenbrand > >>> Acked-by: Cornelia Huck > >>> Signed-off-by: Christian Borntraeger > >>> [rework to use a callback] > >>> --- > >>> v1->v2: replace the fixed string with a callback > >>> > >>> gdbstub.c | 21 ++++++++++++++------- > >>> include/qom/cpu.h | 3 +++ > >>> target-arm/cpu.c | 12 ++++++++++++ > >>> target-arm/cpu64.c | 6 ++++++ > >>> target-ppc/translate_init.c | 10 ++++++++++ > >>> target-s390x/cpu.c | 6 ++++++ > >>> 6 files changed, 51 insertions(+), 7 deletions(-) > > > > Reviewed-by: Peter Maydell > > > > (at least for the generic and ARM related bits). > > Ok, so I will take that and send it via the s390/kvm tree? > Well, Conny will probably do the next round. Will do, unless somebody objects.