From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMRuU-0006ki-J6 for qemu-devel@nongnu.org; Thu, 21 Jan 2016 21:57:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMRuT-0006Gw-Oz for qemu-devel@nongnu.org; Thu, 21 Jan 2016 21:57:14 -0500 Date: Fri, 22 Jan 2016 10:57:02 +0800 From: Fam Zheng Message-ID: <20160122025702.GC24012@ad.usersys.redhat.com> References: <1452218894-2388-1-git-send-email-famz@redhat.com> <1452218894-2388-2-git-send-email-famz@redhat.com> <56A10000.70002@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A10000.70002@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 01/15] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , pbonzini@redhat.com On Thu, 01/21 16:57, Max Reitz wrote: > On 08.01.2016 03:08, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. Its value should be ignored unless > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block drivers fill in the right value, let's clear it explicitly > > right before calling .bdrv_get_block_status. > > > > The "bs->file" condition in bdrv_co_get_block_status is kept now to keep iotest > > case 102 passing, and will be fixed once all drivers return the right file > > pointer. > > > > Signed-off-by: Fam Zheng > > --- > > block/io.c | 38 ++++++++++++++++++++++++++------------ > > block/iscsi.c | 6 ++++-- > > block/mirror.c | 3 ++- > > block/parallels.c | 2 +- > > block/qcow.c | 2 +- > > block/qcow2.c | 2 +- > > block/qed.c | 3 ++- > > block/raw-posix.c | 3 ++- > > block/raw_bsd.c | 3 ++- > > block/sheepdog.c | 2 +- > > block/vdi.c | 2 +- > > block/vmdk.c | 2 +- > > block/vpc.c | 2 +- > > block/vvfat.c | 2 +- > > include/block/block.h | 11 +++++++---- > > include/block/block_int.h | 3 ++- > > qemu-img.c | 7 +++++-- > > 17 files changed, 60 insertions(+), 33 deletions(-) > > Patch itself is good, but the two bdrv_get_block_status_above() calls > you added in qemu-img.c in 25ad8e6e need to be amended now, too. Sure, thanks, will rebase and resend.