From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNdXT-00085V-DI for qemu-devel@nongnu.org; Mon, 25 Jan 2016 04:34:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNdXQ-0006eK-5C for qemu-devel@nongnu.org; Mon, 25 Jan 2016 04:34:23 -0500 Received: from foss.arm.com ([217.140.101.70]:34123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNdXP-0006eB-Vh for qemu-devel@nongnu.org; Mon, 25 Jan 2016 04:34:20 -0500 Date: Mon, 25 Jan 2016 09:36:05 +0000 From: Lorenzo Pieralisi Message-ID: <20160125093604.GA32652@red-moon> References: <1452696603-27611-1-git-send-email-lorenzo.pieralisi@arm.com> <56A2E2CD.80904@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A2E2CD.80904@roeck-us.net> Subject: Re: [Qemu-devel] [PATCH v2] arm64: kernel: fix architected PMU registers unconditional access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guenter Roeck Cc: Mark Rutland , Peter Maydell , Will Deacon , qemu-devel@nongnu.org, linux-arm-kernel@lists.infradead.org Hi Guenter, On Fri, Jan 22, 2016 at 06:17:49PM -0800, Guenter Roeck wrote: > On 01/13/2016 06:50 AM, Lorenzo Pieralisi wrote: > >The Performance Monitors extension is an optional feature of the > >AArch64 architecture, therefore, in order to access Performance > >Monitors registers safely, the kernel should detect the architected > >PMU unit presence through the ID_AA64DFR0_EL1 register PMUVer field > >before accessing them. > > > >This patch implements a guard by reading the ID_AA64DFR0_EL1 register > >PMUVer field to detect the architected PMU presence and prevent accessing > >PMU system registers if the Performance Monitors extension is not > >implemented in the core. > > > >Fixes: 60792ad349f3 ("arm64: kernel: enforce pmuserenr_el0 initialization and restore") > >Signed-off-by: Lorenzo Pieralisi > >Reported-by: Guenter Roeck > >Tested-by: Guenter Roeck > >Cc: Will Deacon > >Cc: Peter Maydell > >Cc: Mark Rutland > > Hi, > > this patch is still missing in mainline. > > Did it get lost ? No it did not, it will be sent shortly, thanks. Lorenzo