From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51445)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aNid4-0008Q3-T8
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 10:00:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aNicz-00024q-0M
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 10:00:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36856)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1aNicy-00024i-RP
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 10:00:24 -0500
Date: Mon, 25 Jan 2016 15:00:20 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160125150020.GD8866@redhat.com>
References: <1447414307-5295-1-git-send-email-berrange@redhat.com>
	<CAFEAcA-rXJoro9zxBODKXqpSX968bWCGseQurz2oBW0aAXUvNg@mail.gmail.com>
	<20160125144741.GC8866@redhat.com>
	<CAFEAcA8V5YHpP6hkLgxm0P_mgdv2cn5ch4J9DYk02F5qXVMNvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA8V5YHpP6hkLgxm0P_mgdv2cn5ch4J9DYk02F5qXVMNvg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] configure: sanity check the glib
 library that pkg-config finds
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On Mon, Jan 25, 2016 at 02:58:22PM +0000, Peter Maydell wrote:
> On 25 January 2016 at 14:47, Daniel P. Berrange <berrange@redhat.com> wrote:
> > AFAIK, no one raised a blocking issue with it.
> 
> I've just found one :-)  which is that it fails on my OSX build system:
> 
> config-temp/qemu-conf.c:5:4: error: unused typedef '_GStaticAssert_5'
> [-Werror,-Wunused-local-typedef]
>    G_STATIC_ASSERT(sizeof(size_t) == GLIB_SIZEOF_SIZE_T);
>    ^
> /sw/include/glib-2.0/glib/gmacros.h:143:96: note: expanded from macro
> 'G_STATIC_ASSERT'
> #define G_STATIC_ASSERT(expr) typedef struct { char
> Compile_Time_Assertion[(expr) ? 1 : -1]; } G_PASTE (_GStaticAssert_,
> __LINE__)
> 
>                         ^
> /sw/include/glib-2.0/glib/gmacros.h:142:47: note: expanded from macro 'G_PASTE'
> #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS
> (identifier1, identifier2)
>                                               ^
> /sw/include/glib-2.0/glib/gmacros.h:141:47: note: expanded from macro
> 'G_PASTE_ARGS'
> #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
>                                               ^
> <scratch space>:170:1: note: expanded from here
> _GStaticAssert_5
> ^
> 1 error generated.
> 
> The annotation of gmacros.h to mark the typedef as deliberately unused
> didn't happen until after the version of glib I have. G_STATIC_ASSERT
> is probably best avoided in QEMU code (we have QEMU_BUILD_BUG_ON
> anyway).

I'm travelling for a few days, but will investigate and re-post an update
once i return.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|