From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOM5P-0006XI-9V
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 04:08:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOM5L-0007Sm-DS
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 04:08:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47569)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1aOM5L-0007SZ-8x
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 04:08:19 -0500
Date: Wed, 27 Jan 2016 09:08:14 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20160127090813.GA2394@work-vm>
References: <1453875065-24326-1-git-send-email-liang.z.li@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453875065-24326-1-git-send-email-liang.z.li@intel.com>
Subject: Re: [Qemu-devel] [PATCH] migration: remove useless code.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liang Li <liang.z.li@intel.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com

* Liang Li (liang.z.li@intel.com) wrote:
> Since 's->state' will be set in migrate_init(), there is no
> need to set it before calling migrate_init(). The code and
> the related comments can be removed.
> 
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> ---
>  migration/migration.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index aaca451..ae38242 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1006,12 +1006,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
>          return;
>      }
>  
> -    /* We are starting a new migration, so we want to start in a clean
> -       state.  This change is only needed if previous migration
> -       failed/was cancelled.  We don't use migrate_set_state() because
> -       we are setting the initial state, not changing it. */
> -    s->state = MIGRATION_STATUS_NONE;
> -

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>


>      s = migrate_init(&params);
>  
>      if (strstart(uri, "tcp:", &p)) {
> -- 
> 1.9.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK