From: Stefan Hajnoczi <stefanha@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
fnstml-hwcolo@cn.fujitsu.com, qemu devel <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>, Gonglei <arei.gonglei@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v14 4/8] Allow creating backup jobs when opening BDS
Date: Wed, 27 Jan 2016 14:04:02 +0000 [thread overview]
Message-ID: <20160127140402.GK26163@stefanha-x1.localdomain> (raw)
In-Reply-To: <1452676712-24239-5-git-send-email-xiecl.fnst@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
On Wed, Jan 13, 2016 at 05:18:28PM +0800, Changlong Xie wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
>
> When opening BDS, we need to create backup jobs for
> image-fleecing.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
> block/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index 58ef2ef..fa05f37 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -22,10 +22,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o
> block-obj-$(CONFIG_LIBSSH2) += ssh.o
> block-obj-y += accounting.o
> block-obj-y += write-threshold.o
> +block-obj-y += backup.o
>
> common-obj-y += stream.o
> common-obj-y += commit.o
> -common-obj-y += backup.o
>
> iscsi.o-cflags := $(LIBISCSI_CFLAGS)
> iscsi.o-libs := $(LIBISCSI_LIBS)
The commit message and description seem outdated. I guess the purpose
of this patch is to link the backup block job into all programs that use
the block layer because you want to add a dependency on the it from core
code.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-27 14:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 9:18 [Qemu-devel] [PATCH v14 0/8] Block replication for continuous checkpoints Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 1/8] unblock backup operations in backing file Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 2/8] Store parent BDS in BdrvChild Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 3/8] Backup: clear all bitmap when doing block checkpoint Changlong Xie
2016-01-27 16:05 ` Stefan Hajnoczi
2016-01-28 2:22 ` Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 4/8] Allow creating backup jobs when opening BDS Changlong Xie
2016-01-27 14:04 ` Stefan Hajnoczi [this message]
2016-01-28 2:22 ` Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 5/8] docs: block replication's description Changlong Xie
2016-02-02 15:20 ` Eric Blake
2016-02-03 3:18 ` Changlong Xie
2016-02-03 3:35 ` Eric Blake
2016-02-03 3:40 ` Wen Congyang
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 6/8] auto complete active commit Changlong Xie
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication Changlong Xie
2016-01-20 0:04 ` Eric Blake
2016-01-20 7:45 ` Changlong Xie
2016-01-27 14:46 ` Stefan Hajnoczi
2016-01-28 1:13 ` Wen Congyang
2016-01-28 15:15 ` Stefan Hajnoczi
2016-01-29 3:13 ` Changlong Xie
2016-01-29 15:46 ` Stefan Hajnoczi
2016-02-01 1:13 ` Wen Congyang
2016-02-02 14:34 ` Stefan Hajnoczi
2016-02-03 1:29 ` Wen Congyang
2016-02-03 9:32 ` Stefan Hajnoczi
2016-02-03 9:55 ` Wen Congyang
2016-02-03 11:25 ` Hailiang Zhang
2016-01-13 9:18 ` [Qemu-devel] [PATCH v14 8/8] support replication driver in blockdev-add Changlong Xie
2016-01-14 1:12 ` [Qemu-devel] [PATCH v14 0/8] Block replication for continuous checkpoints Changlong Xie
2016-01-19 1:27 ` Hailiang Zhang
2016-01-24 13:34 ` Wen Congyang
2016-01-26 16:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127140402.GK26163@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=famz@redhat.com \
--cc=fnstml-hwcolo@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).