From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOSN7-0007A3-Fs for qemu-devel@nongnu.org; Wed, 27 Jan 2016 10:51:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOSN2-0004y7-GI for qemu-devel@nongnu.org; Wed, 27 Jan 2016 10:51:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOSN2-0004xu-Aj for qemu-devel@nongnu.org; Wed, 27 Jan 2016 10:51:00 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1206B19CBBD for ; Wed, 27 Jan 2016 15:50:58 +0000 (UTC) Date: Wed, 27 Jan 2016 17:50:56 +0200 From: "Michael S. Tsirkin" Message-ID: <20160127174949-mutt-send-email-mst@redhat.com> References: <1453903798-28857-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453903798-28857-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: lprosek@redhat.com, qemu-devel@nongnu.org On Wed, Jan 27, 2016 at 03:09:58PM +0100, Gerd Hoffmann wrote: > Actually fixes linux not finding virtio 1.0 device virtqueues after > reboot. Which is new I think, any chance linux kernel virtio code > became more strict in 4.3? > > Signed-off-by: Gerd Hoffmann > --- > hw/virtio/virtio-pci.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 94667e6..8213d94 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -47,6 +47,7 @@ > > static void virtio_pci_bus_new(VirtioBusState *bus, size_t bus_size, > VirtIOPCIProxy *dev); > +static void virtio_pci_reset(DeviceState *qdev); > > /* virtio device */ > /* DeviceState to VirtIOPCIProxy. For use off data-path. TODO: use QOM. */ > @@ -432,8 +433,7 @@ static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) > } > > if (vdev->status == 0) { > - virtio_reset(vdev); > - msix_unuse_all_vectors(&proxy->pci_dev); > + virtio_pci_reset(DEVICE(proxy)); > } > > /* Linux before 2.6.34 drives the device without enabling Aren't there two call sites in virtio_ioport_write? > @@ -1351,8 +1351,7 @@ static void virtio_pci_common_write(void *opaque, hwaddr addr, > } > > if (vdev->status == 0) { > - virtio_reset(vdev); > - msix_unuse_all_vectors(&proxy->pci_dev); > + virtio_pci_reset(DEVICE(proxy)); > } > > break; > -- > 1.8.3.1