From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aOdGt-000548-4b
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 22:29:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aOdGs-0004Yt-BI
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 22:29:23 -0500
Date: Thu, 28 Jan 2016 11:29:13 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160128032913.GL7877@ad.usersys.redhat.com>
References: <1453917600-2663-1-git-send-email-mreitz@redhat.com>
	<1453917600-2663-10-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1453917600-2663-10-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 09/16] blockdev: Use blk_remove_bs() in
	do_drive_del()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

On Wed, 01/27 18:59, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/blockdev.c b/blockdev.c
> index 1044a6a..09d4621 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -2792,7 +2792,7 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict)
>              return;
>          }
>  
> -        bdrv_close(bs);
> +        blk_remove_bs(blk);
>      }
>  
>      /* if we have a device attached to this BlockDriverState
> -- 
> 2.7.0
> 

Reviewed-by: Fam Zheng <famz@redhat.com>