From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOkiJ-0001M0-Dc for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:26:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOkiF-0005LW-8s for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:26:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOkiF-0005LQ-3S for qemu-devel@nongnu.org; Thu, 28 Jan 2016 06:26:07 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A0D8CC0A9CCE for ; Thu, 28 Jan 2016 11:26:06 +0000 (UTC) Date: Thu, 28 Jan 2016 13:26:03 +0200 From: "Michael S. Tsirkin" Message-ID: <20160128132428-mutt-send-email-mst@redhat.com> References: <1453903798-28857-1-git-send-email-kraxel@redhat.com> <20160127174949-mutt-send-email-mst@redhat.com> <1453973605.30975.6.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453973605.30975.6.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] virtio-pci: call pci reset variant when guest clears status. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: lprosek@redhat.com, qemu-devel@nongnu.org On Thu, Jan 28, 2016 at 10:33:25AM +0100, Gerd Hoffmann wrote: > > > if (vdev->status == 0) { > > > - virtio_reset(vdev); > > > - msix_unuse_all_vectors(&proxy->pci_dev); > > > + virtio_pci_reset(DEVICE(proxy)); > > > } > > > > > > /* Linux before 2.6.34 drives the device without enabling > > > > Aren't there two call sites in virtio_ioport_write? > > /me was specifically fixing clear-status code paths mentioned in the > commit message. > > Yes, there is another one, not fully sure what is supposed to happen > there. > > cheers, > Gerd Same thing really - virtio 0 has two equivalent ways to reset a device: write 0 into status or write 0 into PFN register. -- MST