From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOrDp-0004gv-Fj for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOrDk-0006NS-US for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:23:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOrDk-0006NC-Nu for qemu-devel@nongnu.org; Thu, 28 Jan 2016 13:23:04 -0500 Date: Thu, 28 Jan 2016 18:22:59 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160128182259.GG2911@work-vm> References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com> <1452829066-9764-6-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452829066-9764-6-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: amit.shah@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com, quintela@redhat.com * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: > We didn't document x-cpu-throttle-initial/x-cpu-throttle-increment for > commands migrate-set-parameters and query-migrate-parameters. > > Here we add the descriptions for these two options and fix the wrong example > for query-migrate-parameters qmp commands. > Besides, this will also fix the bug that we can't set x-cpu-throttle-initial > and x-cpu-throttle-increment through migrate-set-parameters qmp command. > > Signed-off-by: zhanghailiang (cc'd in Jason who wrote the autothrottle) Reviewed-by: Dr. David Alan Gilbert > --- > qmp-commands.hx | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index db072a6..0a2cded 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3700,6 +3700,10 @@ Set migration parameters > - "compress-level": set compression level during migration (json-int) > - "compress-threads": set compression thread count for migration (json-int) > - "decompress-threads": set decompression thread count for migration (json-int) > +- "x-cpu-throttle-initial": set initial percentage of time guest cpus are > + throttled for auto-coverge (json-int) > +- "x-cpu-throttle-increment": set throttle increasing percentage for > + auto-converge (json-int) > > Arguments: > > @@ -3713,7 +3717,7 @@ EQMP > { > .name = "migrate-set-parameters", > .args_type = > - "compress-level:i?,compress-threads:i?,decompress-threads:i?", > + "compress-level:i?,compress-threads:i?,decompress-threads:i?,x-cpu-throttle-initial:i?,x-cpu-throttle-increment:i?", > .mhandler.cmd_new = qmp_marshal_migrate_set_parameters, > }, > SQMP > @@ -3726,6 +3730,10 @@ Query current migration parameters > - "compress-level" : compression level value (json-int) > - "compress-threads" : compression thread count value (json-int) > - "decompress-threads" : decompression thread count value (json-int) > + - "x-cpu-throttle-initial" : initial percentage of time guest cpus are > + throttled (json-int) > + - "x-cpu-throttle-increment" : throttle increasing percentage for > + auto-converge (json-int) > > Arguments: > > @@ -3734,9 +3742,11 @@ Example: > -> { "execute": "query-migrate-parameters" } > <- { > "return": { > - "decompress-threads", 2, > - "compress-threads", 8, > - "compress-level", 1 > + "decompress-threads": 2, > + "x-cpu-throttle-increment": 10, > + "compress-threads": 8, > + "compress-level": 1, > + "x-cpu-throttle-initial": 20 > } > } > > -- > 1.8.3.1 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK