From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend
Date: Tue, 2 Feb 2016 17:29:03 +0000 [thread overview]
Message-ID: <20160202172903.GD32084@stefanha-x1.localdomain> (raw)
In-Reply-To: <87fuxcpqut.fsf@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]
On Mon, Feb 01, 2016 at 12:17:14PM +0000, Alex Bennée wrote:
>
> Stefan Hajnoczi <stefanha@redhat.com> writes:
>
> > On Fri, Jan 29, 2016 at 04:41:41PM +0000, Alex Bennée wrote:
> >>
> >> Stefan Hajnoczi <stefanha@redhat.com> writes:
> >>
> >> > The GThread coroutine backend was a portable coroutine implementation.
> >> > Over the years all platforms got their own optimized coroutine
> >> > implementations and nothing uses the GThread backend anymore.
> >> >
> >> > In fact, ./configure mentions the GThread backend doesn't work but might
> >> > be useful for debugging. Since GDB macros were added to ease debugging
> >> > of ucontext coroutines, there seems little point in keeping a broken
> >> > backend around.
> >>
> >> Except I found that I couldn't run the ThreadSanitizer without using the
> >> gthread co-routines. So while I totally agree we should dump stuff
> >> that's not used lets make sure no one else relies on it for debugging
> >> stuff as well.
> >
> > Is it still the case that ThreadSanitizer only works with gthread
> > coroutines?
>
> It certainly was very confused about what was going on with the default
> option (sigucontext IIRC?).
Okay, it looks like there is a good reason to keep the GThread backend.
If I have time I'd like to look into the reason why the GThread backend
doesn't pass "make check". I noticed that ide tests were hanging.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-02 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 16:07 [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend Stefan Hajnoczi
2016-01-29 16:41 ` Alex Bennée
2016-02-01 11:37 ` Stefan Hajnoczi
2016-02-01 12:17 ` Alex Bennée
2016-02-02 17:29 ` Stefan Hajnoczi [this message]
2016-02-02 17:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202172903.GD32084@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).