From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQenb-0001lH-4w for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:31:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQenY-0006sM-0E for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:31:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQenX-0006sF-RE for qemu-devel@nongnu.org; Tue, 02 Feb 2016 12:31:27 -0500 Date: Tue, 2 Feb 2016 17:29:03 +0000 From: Stefan Hajnoczi Message-ID: <20160202172903.GD32084@stefanha-x1.localdomain> References: <1454083668-23520-1-git-send-email-stefanha@redhat.com> <87r3h0gwxm.fsf@linaro.org> <20160201113716.GC4642@stefanha-x1.localdomain> <87fuxcpqut.fsf@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jCrbxBqMcLqd4mOl" Content-Disposition: inline In-Reply-To: <87fuxcpqut.fsf@linaro.org> Subject: Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org --jCrbxBqMcLqd4mOl Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 01, 2016 at 12:17:14PM +0000, Alex Benn=E9e wrote: >=20 > Stefan Hajnoczi writes: >=20 > > On Fri, Jan 29, 2016 at 04:41:41PM +0000, Alex Benn=E9e wrote: > >> > >> Stefan Hajnoczi writes: > >> > >> > The GThread coroutine backend was a portable coroutine implementatio= n. > >> > Over the years all platforms got their own optimized coroutine > >> > implementations and nothing uses the GThread backend anymore. > >> > > >> > In fact, ./configure mentions the GThread backend doesn't work but m= ight > >> > be useful for debugging. Since GDB macros were added to ease debugg= ing > >> > of ucontext coroutines, there seems little point in keeping a broken > >> > backend around. > >> > >> Except I found that I couldn't run the ThreadSanitizer without using t= he > >> gthread co-routines. So while I totally agree we should dump stuff > >> that's not used lets make sure no one else relies on it for debugging > >> stuff as well. > > > > Is it still the case that ThreadSanitizer only works with gthread > > coroutines? >=20 > It certainly was very confused about what was going on with the default > option (sigucontext IIRC?). Okay, it looks like there is a good reason to keep the GThread backend. If I have time I'd like to look into the reason why the GThread backend doesn't pass "make check". I noticed that ide tests were hanging. Stefan --jCrbxBqMcLqd4mOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWsOdfAAoJEJykq7OBq3PIZsEIAJSV7laWWXy6rauMxjlx1tFe mOxZr6u3c/I2UyDF5VZMU3W3tHeQImyQehbmde5tkd54s0OaMQ7RdSMmf5MT1mqf O3Fnv4PTXhumGe/8erAUJ52TbtFPOEkSeSpOYHxL73KPyttJ0M7gx2n+WtfkJ6lt isQU/wqfsmaBUZybiZKTGx8MIdzXPJsCth9hSt4MTK7JTThApVSn40VJELTqipG4 x907VqyNR+v9R7yjZP7mqwrvu14DwpXr9/rURnLEWAMXuIC84UXLRxQ8xQpnuz64 lRQM4mWAZ/PBkL92BRBSbt+YrD+ZV1dln8UiW24CaC93vyQGzI2uBuyV+w1geKM= =n5cC -----END PGP SIGNATURE----- --jCrbxBqMcLqd4mOl--