Re: [Qemu-devel] [PATCH] coroutine: drop GThread coroutine backend

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Fri, Jan 29, 2016 at 04:07:48PM +0000, Stefan Hajnoczi wrote:
> The GThread coroutine backend was a portable coroutine implementation.
> Over the years all platforms got their own optimized coroutine
> implementations and nothing uses the GThread backend anymore.
> 
> In fact, ./configure mentions the GThread backend doesn't work but might
> be useful for debugging.  Since GDB macros were added to ease debugging
> of ucontext coroutines, there seems little point in keeping a broken
> backend around.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure                |  19 ++---
>  util/coroutine-gthread.c | 198 -----------------------------------------------
>  2 files changed, 5 insertions(+), 212 deletions(-)
>  delete mode 100644 util/coroutine-gthread.c

NACK

Alex Bennee pointed out that ThreadSanitizer needs the GThread backend
because it cannot cope with stack switching.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]