From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQpf4-0004S6-7f for qemu-devel@nongnu.org; Wed, 03 Feb 2016 00:07:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQpf2-0000MH-Qu for qemu-devel@nongnu.org; Wed, 03 Feb 2016 00:07:26 -0500 Date: Wed, 3 Feb 2016 16:06:10 +1100 From: David Gibson Message-ID: <20160203050610.GJ15080@voom.fritz.box> References: <145442963048.1539.13602468921796488810.stgit@localhost> <145442965530.1539.10919507514033766738.stgit@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/qIPZgKzMPM+y5U5" Content-Disposition: inline In-Reply-To: <145442965530.1539.10919507514033766738.stgit@localhost> Subject: Re: [Qemu-devel] [PATCH v6 4/5] util: [ppc] Use new error_report_abort() instead of abort() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Alexander Graf , Thomas Huth , "open list:Overall" , Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , "open list:PowerPC" , Paolo Bonzini , "Dr . David Alan Gilbert" --/qIPZgKzMPM+y5U5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 02, 2016 at 05:14:15PM +0100, Llu=EDs Vilanova wrote: > Signed-off-by: Llu=EDs Vilanova > --- > target-ppc/kvm.c | 4 ++-- > target-ppc/kvm_ppc.h | 15 +++++++++------ > target-ppc/mmu-hash32.c | 5 +++-- > target-ppc/mmu_helper.c | 3 +-- > 4 files changed, 15 insertions(+), 12 deletions(-) >=20 > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c > index 1bb87e6..b743811 100644 > --- a/target-ppc/kvm.c > +++ b/target-ppc/kvm.c > @@ -587,7 +587,7 @@ static void kvm_get_one_spr(CPUState *cs, uint64_t id= , int spr) > =20 > default: > /* Don't handle this size yet */ > - abort(); > + error_report_abort("Unhandled size: %d", id & KVM_REG_SIZE_M= ASK); > } > } > } > @@ -617,7 +617,7 @@ static void kvm_put_one_spr(CPUState *cs, uint64_t id= , int spr) > =20 > default: > /* Don't handle this size yet */ > - abort(); > + error_report_abort("Unhandled size: %d", id & KVM_REG_SIZE_MASK); > } > =20 > ret =3D kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®); > diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h > index 62406ce..f82582e 100644 > --- a/target-ppc/kvm_ppc.h > +++ b/target-ppc/kvm_ppc.h > @@ -9,6 +9,9 @@ > #ifndef __KVM_PPC_H__ > #define __KVM_PPC_H__ > =20 > +#include "qemu/error-report.h" > + > + > #define TYPE_HOST_POWERPC_CPU "host-" TYPE_POWERPC_CPU > =20 > #ifdef CONFIG_KVM > @@ -215,36 +218,36 @@ static inline int kvmppc_get_htab_fd(bool write) > static inline int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, > int64_t max_ns) > { > - abort(); > + error_report_abort(" "); Nack. The empty message report is just awful. I don't think we should feel the need to get rid of every bare abort() or assert(). --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --/qIPZgKzMPM+y5U5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWsYrCAAoJEGw4ysog2bOS4zsQAK1TXBS8QiP/KN7/SreMgTyq uI+/hIRk50DfZPAqfgBhnaIW85yo6HutCvZQO4xmFgPtQp3Cg5Gm+fjZGa0WccxD h8Ix0KIhwbySgavy+q3os8SOaLN3hjZ7b6Ja0o2LB4OIDyvwTz5IFFVfB3lRwjmX VB0e2hA39qSFpZswAtkGwO8yXx2cJODME6aTu77FRzUdaXGWcWZKf+ERuvqK8f3w F7GQ9GOKTa2JcqGOPaP+U7eUeQZPdsygvC9gyeYUChnxtXAG4MAvZRecbTbzVb/L wv3LOVm19/999w/AP4TOLtcDAAqSL0WCkAuugmHvQGlmOIxUQXJ7FJY0Assl5bRT 51iwrL0711CjGj5YvzlzJaxKGmYq5lmA9Tf2EMURYhavtN0+HPxjrnL8PjVTmx56 8HsQTzA8yQc4ugmGuQ+YzJljcnimdsd8ITkKBPcmzfz1jtJYSoDCAcXRXRb45p2n QiW5rV/ilxpOAoJvm37oMaF5lXT99XEL+U2b3LRU/XXr0iNOeQ9FF84ZF7pazDnS J6U+/hvNo7TiP1PJLzkTtA8EZuZtVIkC4UHR614bxKQvcVT////6/FYwQqYbDeOE GS2clfSlJYr6pCF4UHLDnL2NSS7Ic6/DP+ZjoYNjvbhFUyLUS/5q0qXqQF8cRVEv uTt9hzsDFSYl7tt/2tNq =dRlb -----END PGP SIGNATURE----- --/qIPZgKzMPM+y5U5--