From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRGi5-0007kB-AU for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:00:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRGhz-00025Y-IR for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:00:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRGhz-00025U-Do for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:00:15 -0500 Date: Thu, 4 Feb 2016 15:30:11 +0530 From: Amit Shah Message-ID: <20160204100011.GC20527@grmbl.mre> References: <20160204092007.31588.66396.stgit@bahia.huguette.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160204092007.31588.66396.stgit@bahia.huguette.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] migration: fix bad string passed to error_report() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: qemu-devel@nongnu.org, Juan Quintela On (Thu) 04 Feb 2016 [10:20:07], Greg Kurz wrote: > state->name does not contain a terminating '\0' and you may get: >=20 > Machine type received is 'pseries-2.3y=EF=BF=BD?' and local is 'pseries= -2.4' > load of migration failed: Invalid argument >=20 > Let's add a precision modifier to fix this. >=20 > Signed-off-by: Greg Kurz Reviewed-by: Amit Shah Amit