From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRGnZ-00027i-SM for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:06:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRGnU-0003IU-RU for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:06:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRGnU-0003IQ-M5 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:05:56 -0500 Date: Thu, 4 Feb 2016 15:35:52 +0530 From: Amit Shah Message-ID: <20160204100552.GD20527@grmbl.mre> References: <1453875065-24326-1-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453875065-24326-1-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [PATCH] migration: remove useless code. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com On (Wed) 27 Jan 2016 [14:11:05], Liang Li wrote: > Since 's->state' will be set in migrate_init(), there is no > need to set it before calling migrate_init(). The code and > the related comments can be removed. > > Signed-off-by: Liang Li > --- > migration/migration.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index aaca451..ae38242 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -1006,12 +1006,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, > return; > } > > - /* We are starting a new migration, so we want to start in a clean > - state. This change is only needed if previous migration > - failed/was cancelled. We don't use migrate_set_state() because > - we are setting the initial state, not changing it. */ > - s->state = MIGRATION_STATUS_NONE; > - Looks fine. This was added to ensure a proper init value, but commit 389775d added the init in migrate_init, so this is now redundant. Reviewed-by: Amit Shah Amit