From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRHBA-0006hR-Qx for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:30:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRHB7-0000nQ-Iq for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:30:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRHB7-0000nM-Dg for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:30:21 -0500 Date: Thu, 4 Feb 2016 16:00:18 +0530 From: Amit Shah Message-ID: <20160204103018.GF20527@grmbl.mre> References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com> <1452829066-9764-6-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452829066-9764-6-git-send-email-zhang.zhanghailiang@huawei.com> Subject: Re: [Qemu-devel] [PATCH 5/6] qmp-commands.hx: Fix the missing options for migration parameters commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang Cc: peter.huangpeng@huawei.com, qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com On (Fri) 15 Jan 2016 [11:37:45], zhanghailiang wrote: > We didn't document x-cpu-throttle-initial/x-cpu-throttle-increment for > commands migrate-set-parameters and query-migrate-parameters. > > Here we add the descriptions for these two options and fix the wrong example > for query-migrate-parameters qmp commands. > Besides, this will also fix the bug that we can't set x-cpu-throttle-initial > and x-cpu-throttle-increment through migrate-set-parameters qmp command. > > Signed-off-by: zhanghailiang > --- > qmp-commands.hx | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index db072a6..0a2cded 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -3700,6 +3700,10 @@ Set migration parameters > - "compress-level": set compression level during migration (json-int) > - "compress-threads": set compression thread count for migration (json-int) > - "decompress-threads": set decompression thread count for migration (json-int) > +- "x-cpu-throttle-initial": set initial percentage of time guest cpus are > + throttled for auto-coverge (json-int) typo, should be converge. No need to re-send the series again unless a respin is required. > +- "x-cpu-throttle-increment": set throttle increasing percentage for > + auto-converge (json-int) Amit