From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1aRHbV-0005Is-I8
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:57:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1aRHbS-0006OC-C1
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:57:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1aRHbS-0006O5-7K
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:57:34 -0500
Date: Thu, 4 Feb 2016 16:27:30 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20160204105730.GH20527@grmbl.mre>
References: <1452829066-9764-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1452829066-9764-3-git-send-email-zhang.zhanghailiang@huawei.com>
	<20160204104700.GG20527@grmbl.mre> <20160204105016.GB2427@work-vm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160204105016.GB2427@work-vm>
Subject: Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of
	MigrationState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: peter.huangpeng@huawei.com, quintela@redhat.com, zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org

On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote:
> * Amit Shah (amit.shah@redhat.com) wrote:
> > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote:
> > > Rename the 'file' member of MigrationState to 'to_dst_file'.
> > 
> > Why?
> > 
> > (Use this space to explain why you're doing it, rather than repeating
> > the first line of the commit.  It helps when reviewing the git logs
> > later.)
> 
> I think the simple answer is consistency; now we've got a bidirectional
> connection we've already got to_src_file, from_src_file and from_dst_file,
> so 'file' is an oddity that I was too lazy to rename previously.

Sure, I just mean we need better commit description.  Just provide
one, and I'll use that when doing the pull req.

Thanks,

		Amit