From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: fix bad string passed to error_report()
Date: Thu, 4 Feb 2016 11:18:03 +0100 [thread overview]
Message-ID: <20160204111803.0ee3ebb0@bahia.huguette.org> (raw)
In-Reply-To: <20160204100011.GC20527@grmbl.mre>
On Thu, 4 Feb 2016 15:30:11 +0530
Amit Shah <amit.shah@redhat.com> wrote:
> On (Thu) 04 Feb 2016 [10:20:07], Greg Kurz wrote:
> > state->name does not contain a terminating '\0' and you may get:
> >
> > Machine type received is 'pseries-2.3y�?' and local is 'pseries-2.4'
> > load of migration failed: Invalid argument
> >
> > Let's add a precision modifier to fix this.
> >
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Amit
>
I forgot to mention that this patch fixes:
61964c23e5ddd5a33f15699e45ce126f879e3e33 "migration: Add configuration section"
Cc'ing stable since this is a 2.4.0 commit and it may *theorically* lead to
a crash (even if that is very unlikely to occur).
Also Cc'ing trivial.
Thanks !
--
Greg
next prev parent reply other threads:[~2016-02-04 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 9:20 [Qemu-devel] [PATCH] migration: fix bad string passed to error_report() Greg Kurz
2016-02-04 10:00 ` Amit Shah
2016-02-04 10:18 ` Greg Kurz [this message]
2016-02-04 15:47 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204111803.0ee3ebb0@bahia.huguette.org \
--to=gkurz@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).