From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aRGzP-0006qN-8D
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:18:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aRGzL-0006Zz-4t
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:18:15 -0500
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:44100)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1aRGzK-0006Ze-Qf
	for qemu-devel@nongnu.org; Thu, 04 Feb 2016 05:18:11 -0500
Received: from localhost
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Thu, 4 Feb 2016 10:18:09 -0000
Date: Thu, 4 Feb 2016 11:18:03 +0100
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20160204111803.0ee3ebb0@bahia.huguette.org>
In-Reply-To: <20160204100011.GC20527@grmbl.mre>
References: <20160204092007.31588.66396.stgit@bahia.huguette.org>
	<20160204100011.GC20527@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] migration: fix bad string passed to
	error_report()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On Thu, 4 Feb 2016 15:30:11 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Thu) 04 Feb 2016 [10:20:07], Greg Kurz wrote:
> > state->name does not contain a terminating '\0' and you may get:
> >=20
> > Machine type received is 'pseries-2.3y=EF=BF=BD?' and local is 'pseries=
-2.4'
> > load of migration failed: Invalid argument
> >=20
> > Let's add a precision modifier to fix this.
> >=20
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com> =20
>=20
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>=20
> 		Amit
>=20

I forgot to mention that this patch fixes:

61964c23e5ddd5a33f15699e45ce126f879e3e33 "migration: Add configuration sect=
ion"

Cc'ing stable since this is a 2.4.0 commit and it may *theorically* lead to
a crash (even if that is very unlikely to occur).

Also Cc'ing trivial.

Thanks !

--
Greg