qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com,
	alex.williamson@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] vfio: make the 4 bytes aligned for capability size
Date: Thu, 4 Feb 2016 13:28:07 +0200	[thread overview]
Message-ID: <20160204132802-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <de40c86c56dfdd7ee97781c21e2cdc2203c3c36d.1454483002.git.chen.fan.fnst@cn.fujitsu.com>

On Thu, Feb 04, 2016 at 09:31:06AM +0800, Cao jin wrote:
> From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> 
> this function search the capability from the end, the last
> size should 0x100 - pos, not 0xff - pos.
> 
> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/vfio/pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 49f3d2d..e671506 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1505,7 +1505,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev)
>   */
>  static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos)
>  {
> -    uint8_t tmp, next = 0xff;
> +    uint8_t tmp;
> +    uint16_t next = PCI_CONFIG_SPACE_SIZE;
>  
>      for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp;
>           tmp = pdev->config[tmp + 1]) {
> -- 
> 1.9.3
> 
> 

  reply	other threads:[~2016-02-04 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  1:31 [Qemu-devel] [PATCH 0/4] vfio-pci: pass the aer error to guest, part1 Cao jin
2016-02-04  1:31 ` [Qemu-devel] [PATCH 1/4] pcie: modify the capability size assert Cao jin
2016-02-04  1:31 ` [Qemu-devel] [PATCH 2/4] vfio: make the 4 bytes aligned for capability size Cao jin
2016-02-04 11:28   ` Michael S. Tsirkin [this message]
2016-02-04  1:31 ` [Qemu-devel] [PATCH 3/4] aer: impove pcie_aer_init to support vfio device Cao jin
2016-02-04  1:31 ` [Qemu-devel] [PATCH 4/4] pcie_aer: expose pcie_aer_msg() interface Cao jin
2016-02-04 11:28 ` [Qemu-devel] [PATCH 0/4] vfio-pci: pass the aer error to guest, part1 Michael S. Tsirkin
2016-02-05  4:53   ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204132802-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).