From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRI5A-0002Ih-B0 for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:28:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRI55-0004Yi-KY for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:28:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRI55-0004Ye-Fr for qemu-devel@nongnu.org; Thu, 04 Feb 2016 06:28:11 -0500 Date: Thu, 4 Feb 2016 13:28:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20160204132802-mutt-send-email-mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 2/4] vfio: make the 4 bytes aligned for capability size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: chen.fan.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com, qemu-devel@nongnu.org On Thu, Feb 04, 2016 at 09:31:06AM +0800, Cao jin wrote: > From: Chen Fan > > this function search the capability from the end, the last > size should 0x100 - pos, not 0xff - pos. > > Signed-off-by: Chen Fan > Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin > --- > hw/vfio/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 49f3d2d..e671506 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -1505,7 +1505,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev) > */ > static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos) > { > - uint8_t tmp, next = 0xff; > + uint8_t tmp; > + uint16_t next = PCI_CONFIG_SPACE_SIZE; > > for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp; > tmp = pdev->config[tmp + 1]) { > -- > 1.9.3 > >