* [Qemu-devel] [PATCH] migration: move page_cache.c to migration/
@ 2016-02-04 11:03 Paolo Bonzini
2016-02-04 15:27 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2016-02-04 11:03 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
page_cache.c is part of the XBZRLE implementation, move it to the right
directory.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile.objs | 1 -
migration/Makefile.objs | 2 +-
page_cache.c => migration/page_cache.c | 0
3 files changed, 1 insertion(+), 2 deletions(-)
rename page_cache.c => migration/page_cache.c (100%)
diff --git a/Makefile.objs b/Makefile.objs
index 06b95c7..f950b0f 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/
common-obj-y += migration/
common-obj-y += qemu-char.o #aio.o
-common-obj-y += page_cache.o
common-obj-y += qjson.o
common-obj-$(CONFIG_SPICE) += spice-qemu-char.o
diff --git a/migration/Makefile.objs b/migration/Makefile.objs
index 0cac6d7..e5778de 100644
--- a/migration/Makefile.objs
+++ b/migration/Makefile.objs
@@ -1,7 +1,7 @@
common-obj-y += migration.o tcp.o
common-obj-y += vmstate.o
common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o
-common-obj-y += xbzrle.o postcopy-ram.o
+common-obj-y += xbzrle.o page_cache.o postcopy-ram.o
common-obj-$(CONFIG_RDMA) += rdma.o
common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o
diff --git a/page_cache.c b/migration/page_cache.c
similarity index 100%
rename from page_cache.c
rename to migration/page_cache.c
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] migration: move page_cache.c to migration/
2016-02-04 11:03 [Qemu-devel] [PATCH] migration: move page_cache.c to migration/ Paolo Bonzini
@ 2016-02-04 15:27 ` Dr. David Alan Gilbert
2016-02-04 16:01 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2016-02-04 15:27 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> page_cache.c is part of the XBZRLE implementation, move it to the right
> directory.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Does that need tests/Makefile updating - I see:
tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y)
I'm OK with moving this, although I didn't when I moved everything
else because there's nothing stopping anyone using it outside of migration.
Dave
> ---
> Makefile.objs | 1 -
> migration/Makefile.objs | 2 +-
> page_cache.c => migration/page_cache.c | 0
> 3 files changed, 1 insertion(+), 2 deletions(-)
> rename page_cache.c => migration/page_cache.c (100%)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 06b95c7..f950b0f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/
>
> common-obj-y += migration/
> common-obj-y += qemu-char.o #aio.o
> -common-obj-y += page_cache.o
> common-obj-y += qjson.o
>
> common-obj-$(CONFIG_SPICE) += spice-qemu-char.o
> diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> index 0cac6d7..e5778de 100644
> --- a/migration/Makefile.objs
> +++ b/migration/Makefile.objs
> @@ -1,7 +1,7 @@
> common-obj-y += migration.o tcp.o
> common-obj-y += vmstate.o
> common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o
> -common-obj-y += xbzrle.o postcopy-ram.o
> +common-obj-y += xbzrle.o page_cache.o postcopy-ram.o
>
> common-obj-$(CONFIG_RDMA) += rdma.o
> common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o
> diff --git a/page_cache.c b/migration/page_cache.c
> similarity index 100%
> rename from page_cache.c
> rename to migration/page_cache.c
> --
> 2.5.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-04 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-04 11:03 [Qemu-devel] [PATCH] migration: move page_cache.c to migration/ Paolo Bonzini
2016-02-04 15:27 ` Dr. David Alan Gilbert
2016-02-04 16:01 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).