From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRM4y-0007Vl-GC for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:44:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRM4u-0005Co-FU for qemu-devel@nongnu.org; Thu, 04 Feb 2016 10:44:20 -0500 Date: Thu, 4 Feb 2016 16:44:06 +0100 From: Kevin Wolf Message-ID: <20160204154406.GF2314@noname> References: <1454417864-18774-1-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454417864-18774-1-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben: > This series of patches expands the syntax of the qemu-img, > qemu-nbd and qemu-io commands to make them more flexible. > > v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04354.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03381.html > v4: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg04984.html > > First all three gain a --object parameter, which allows > instantiation of user creatable object types. The immediate > use case is to allow for creation of the 'secret' object > type to pass passwords for curl, iscsi and rbd drivers. > For qemu-nbd this will also be needed to create TLS > certificates for encryption support. > > Then all three gain a '--image-opts' parameter which causes > the positional filenames to be interepreted as option strings > rather tha nplain filenames. This avoids the need to use the > JSON syntax, or to add custom CLI args for each block backend > option that exists. The immediate use case is to allow the > user to specify the ID of the 'secret' object they just created. > > Finally, there are a few small cleanup patches > > The first 4 patches in this series are a pre-requisite for > 3 other series > > - Support for TLS in NBD > - Support for secrets for passwd auth in curl, rbd, iscsi > (fixes a CVE issue in libvirt) > - Support for LUKS encryption passwords Apart from the few comments that were made (including my own that I just sent), this looks good to me. Kevin