From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()
Date: Fri, 5 Feb 2016 12:39:20 +0100 [thread overview]
Message-ID: <20160205123920.648985de.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160205104559.21017.3686.stgit@bahia.huguette.org>
On Fri, 05 Feb 2016 11:46:04 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> After the call to virtio_vdev_has_feature(), we only care for legacy
> devices, so we don't need the extra check in virtio_is_big_endian().
>
> Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN
> may only happen on a virtio_load() path that cannot lead here), so we
> don't need the assert() either.
>
> This open codes the device_endian checking in vhost_needs_vring_endian().
> It also adds a comment to explain the logic, as recent reviews showed the
> cross-endian tweaks aren't that obvious.
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> hw/virtio/vhost.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2016-02-05 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 10:39 [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup Greg Kurz
2016-02-05 10:43 ` [Qemu-devel] [PATCH v4 1/6] virtio-net: use the backend cross-endian capabilities Greg Kurz
2016-02-05 11:33 ` Cornelia Huck
2016-02-05 15:41 ` Greg Kurz
2016-02-05 10:45 ` [Qemu-devel] [PATCH v4 2/6] vhost-net: revert support of cross-endian vnet headers Greg Kurz
2016-02-05 10:45 ` [Qemu-devel] [PATCH v4 3/6] virtio: move cross-endian helper to vhost Greg Kurz
2016-02-05 10:45 ` [Qemu-devel] [PATCH v4 4/6] vhost: move virtio 1.0 check to cross-endian helper Greg Kurz
2016-02-05 13:06 ` Laurent Vivier
2016-02-05 10:46 ` [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian() Greg Kurz
2016-02-05 11:39 ` Cornelia Huck [this message]
2016-02-05 13:02 ` Laurent Vivier
2016-02-05 10:46 ` [Qemu-devel] [PATCH v4 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets Greg Kurz
2016-02-05 13:07 ` [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup Laurent Vivier
2016-02-10 10:22 ` Laurent Vivier
2016-02-16 9:57 ` Greg Kurz
2016-02-16 10:04 ` Michael S. Tsirkin
2016-02-16 10:07 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205123920.648985de.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).