From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRj71-0000BF-E9 for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRj6w-0006YI-Ef for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:19:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRj6w-0006YE-8k for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:19:54 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id E3261C0AC93B for ; Fri, 5 Feb 2016 16:19:53 +0000 (UTC) Date: Fri, 5 Feb 2016 17:19:50 +0100 From: Igor Mammedov Message-ID: <20160205171950.4bf5ea3a@nial.brq.redhat.com> In-Reply-To: <20160205153907.GS26314@thinpad.lan.raisama.net> References: <1454586455-10202-1-git-send-email-imammedo@redhat.com> <1454586455-10202-7-git-send-email-imammedo@redhat.com> <20160205153907.GS26314@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/9] pc: acpi: drop not needed intermediate bitmap cpu->found_cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Fri, 5 Feb 2016 13:39:07 -0200 Eduardo Habkost wrote: > On Thu, Feb 04, 2016 at 12:47:33PM +0100, Igor Mammedov wrote: > > cpu->found_cpus bitmap is used for setting present > > flag in CPON AML package at start up. But it takes > > a bunch of code to fill bitmap and cloud be simplified > > by calling qemu_get_cpu_by_arch_id(apic_id) directly. > > > > Hence do so and remove not used anymore bitmap > > with related utilities, which saves us ~32LOC > > and also would simplify consolidating APCI parts > > of CPU hotplug. > > > > Signed-off-by: Igor Mammedov > > This makes the code loops through all smp_cpus CPUs max_cpus > times, instead of just looping through the smp_cpus CPUs once. Yep, that looks bad. I'll redo it using possible_cpu_arch_ids(), it is a little bit bigger refactoring. > > I'm all for making the code simpler, and there's an upper bound: > looking at CPU objects 64k times (because MAX_CPUMASK_BITS is > 255). But I want to make sure we agree this is an optimization we > want to drop. >