From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSn8B-0000kP-7B for qemu-devel@nongnu.org; Mon, 08 Feb 2016 09:49:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSn88-0005YQ-0s for qemu-devel@nongnu.org; Mon, 08 Feb 2016 09:49:35 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSn87-0005YK-QK for qemu-devel@nongnu.org; Mon, 08 Feb 2016 09:49:31 -0500 Received: by mail-wm0-x234.google.com with SMTP id p63so118955399wmp.1 for ; Mon, 08 Feb 2016 06:49:31 -0800 (PST) Date: Mon, 8 Feb 2016 14:49:28 +0000 From: Stefan Hajnoczi Message-ID: <20160208144928.GA31586@stefanha-x1.localdomain> References: <1450767586-28794-1-git-send-email-den@openvz.org> <5693B245.6020006@de.ibm.com> <5693BB8B.2040909@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <5693BB8B.2040909@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , Christian Borntraeger , qemu-devel@nongnu.org --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2016 at 05:26:19PM +0300, Denis V. Lunev wrote: > On 01/11/2016 04:46 PM, Christian Borntraeger wrote: > >On 12/22/2015 07:59 AM, Denis V. Lunev wrote: > >>error: Failed to start domain rhel7 > >>error: internal error: process exited while connecting to monitor: > >> 2015-12-22T06:55:18.812637Z qemu-system-x86_64: > >> -drive file=/var/lib/libvirt/images/rhel7.qcow2,if=none, > >> id=drive-scsi0-0-0-0,format=qcow2,cache=none,aio=native: > >> aio=native was specified, but it requires cache.direct=on, > >> which was not specified. > >> > >>cache=none option was specified as seen above while the VM is unable to > >>start. The patch properly passed BDRV_O_NOCACHE to underlying layer. > >> > >>The problem is revealed with > >> commit d657c0c289e944fc22289f5c318f48da87d79dcb > >> Author: Kevin Wolf > >> Date: Tue Dec 15 11:35:36 2015 +0100 > >> > >> raw-posix: Make aio=native option binding > >> > >>Signed-off-by: Denis V. Lunev > >>CC: Kevin Wolf > >Acked-by: Christian Borntraeger > > > >Without this patch all libvirt xmls with > >cache='none' io='native' > >are broken. We should apply this patch (or something else) > >soon. > > > exactly! For the record, the bug has been fixed. I went back and bisected: Kevin Wolf fixed the issue in "block: Fix .bdrv_open flags" (82dc8b411040fa8a7418a012ff39b8d06f68e639). Stefan --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWuKr4AAoJEJykq7OBq3PITk8H/20EQuZgyD3bgmUJ+rI5C5bB CauGPpJrG2LKXW6YtiwVWzU68AsE6CnS8OZCDzgvLsXI0k8YYvwx3JviP/+bbbIV Vd7EarMfVKi+Ux1tuhbZ3FAZo/gakyL08lcO6JO3bFuyzKArdj2r1D38zitK+BGs FtSVcyJ7JwMMd5Xh4macwZFmz7f+lEI8VvJLO9lnPwXHCYHdjJXDpEr1Jc2bLK1a eVpBImmrAhn2cClj6doR6cCt5d17DV4P+aGGWu311W2/OCHiwL5MzIZVS9HqXeuE 2mEOBajQQ1wY3m/1dCu8iRHk1tU/cr9amAC3A44xRM0+G3D5PbYvA+t0LGN1zJ4= =6h0B -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--